Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modal.js should consider shadowRoot #2778

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

thomson02
Copy link

consider the possibility that document.activeElement could be a shadowRoot. In this case recursively look inside shadowRoots until the actual focused child is found.

  • [ x] Bug fix
  • New feature
  • Chore
  • Breaking change
  • [ x] There is an open issue which this change addresses
  • [x ] I have read the CONTRIBUTING document.
  • [ x] My commits follow the Git Commit Guidelines
  • [ x] My code follows the code style of this project.
  • My change requires a change to the documentation.
    • I have updated the documentation accordingly.
  • My change requires a change to Typescript typings.
    • I have updated the typings accordingly.
  • I have added tests to cover my changes.
  • [x ] All new and existing tests passed.

Fixes #2777

consider the possibility that document.activeElement could be a shadowRoot. In this case recursively look inside shadowRoots until the actual focused child is found.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Shift+Tab Model with ShadowRoot
1 participant