Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Agency lite landing page #398

Merged
merged 7 commits into from
May 28, 2024
Merged

Conversation

davidfischer
Copy link
Collaborator

  • Detail video overviews
  • Need approval on the quote
  • Link to the new page from the ad design specs and FAQ

- Detail video overviews
- Need approval on the quote
- Link to the new page from the ad design specs and FAQ
@davidfischer davidfischer requested review from a team and ericholscher January 10, 2024 00:39
Copy link
Member

@ericholscher ericholscher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We could probably use a bit more about the workflow here, similar to what we discuss in the ad guide: https://www.ethicalads.io/advertiser-guide/#collaborate-with-us-to-get-great-results

I like the "timeline" aspect of it versus just a high-level explanation of some of the ideas. I don't think we need it for this iteration, but could be a "nice to have" for v2.

- Link also from the ads guide
Copy link
Member

@ericholscher ericholscher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good overall, just a couple nits on consistent sentence endings 💯

ethicalads-theme/templates/ea/agency-lite.html Outdated Show resolved Hide resolved
ethicalads-theme/templates/ea/agency-lite.html Outdated Show resolved Hide resolved
davidfischer and others added 2 commits January 12, 2024 09:01
Co-authored-by: Eric Holscher <25510+ericholscher@users.noreply.github.com>
Co-authored-by: Eric Holscher <25510+ericholscher@users.noreply.github.com>
@davidfischer
Copy link
Collaborator Author

Sadly, the person for our testimonial doesn't work there anymore. I'm working on a different one.

@davidfischer davidfischer added the blocked This is blocked on either another feature, another review or something else label Apr 17, 2024
@davidfischer davidfischer removed the blocked This is blocked on either another feature, another review or something else label May 22, 2024
@davidfischer
Copy link
Collaborator Author

I got an approved testimonial which is available here: https://ethicaladsio--398.org.readthedocs.build/advertisers/help-with-your-ads/

Copy link
Member

@ericholscher ericholscher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good with a bit of copy cleanup.

content/pages/agency-lite.md Outdated Show resolved Hide resolved
ethicalads-theme/templates/ea/agency-lite.html Outdated Show resolved Hide resolved
ethicalads-theme/templates/ea/agency-lite.html Outdated Show resolved Hide resolved
ethicalads-theme/templates/ea/agency-lite.html Outdated Show resolved Hide resolved
davidfischer and others added 2 commits May 23, 2024 11:39
Co-authored-by: Eric Holscher <25510+ericholscher@users.noreply.github.com>
- agency-lite -> help-with-your-ads
- CheckMK -> Checkmk
- Fix some wording
Copy link
Member

@ericholscher ericholscher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look great 👍

@davidfischer davidfischer merged commit 8a56ac9 into main May 28, 2024
2 checks passed
@davidfischer davidfischer deleted the davidfischer/agency-lite-landing-page branch May 28, 2024 22:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants