Improvements for filter forms #250
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I have wanted to play with these more. This is the templates used for the filters at the top of model listing views. A couple changes I've wanted: - All filters are actual filter instances. Project, version, and organization have some one-off, pseudo filters made in HTML - Filter form shows fields as a `ui sub header` with the label above the selected field value. This shows the active filter and value, instead of hiding the value - I want to add an icon for filters - Filters should use `active` mode from SUI config. This changes the default text in the dropdown. Leaving this open for now so I can return. I was playing with this for unrelated reasons.
3 tasks
agjohnson
added a commit
that referenced
this pull request
May 17, 2024
This drops the custom API driven filters and relies on application FilterSet instances instead, matching the rest of the filter fields. Because of this, we are able to delete much of the JS and API logic from the dashboard side. - Fixes #343 - Closes #250 - Requires changes on our application filters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have wanted to play with these more. This is the templates used for
the filters at the top of model listing views.
A couple changes I've wanted:
organization have some one-off, pseudo filters made in HTML
ui sub headerwith the label above theselected field value. This shows the active filter and value, instead
of hiding the value
activemode from SUI config. This changes thedefault text in the dropdown.
Leaving this open for now so I can return. I was playing with this for
unrelated reasons.
TODO:
.ui.sub.headermargin-top