Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs: basic docs for SAML SSO #11288

Merged
merged 5 commits into from
May 20, 2024
Merged

Docs: basic docs for SAML SSO #11288

merged 5 commits into from
May 20, 2024

Conversation

stsewd
Copy link
Member

@stsewd stsewd commented Apr 17, 2024

We still need to figure out a couple of things, but I think it doesn't hurt to have some basic docs about this feature.

This follows the same structure from other guides related to SSO, preview at https://docs--11288.org.readthedocs.build/en/11288/guides/set-up-single-sign-on-saml.html.

Ref #11262


馃摎 Documentation previews 馃摎

stsewd and others added 4 commits April 17, 2024 13:12
We still need to figure out a couple of things, but I think it doesn't
hurt to have some basic docs about this feature.

Ref #11262
@stsewd stsewd marked this pull request as ready for review May 1, 2024 18:51
@stsewd stsewd requested a review from a team as a code owner May 1, 2024 18:51
@stsewd stsewd requested a review from agjohnson May 1, 2024 18:51
@stsewd
Copy link
Member Author

stsewd commented May 1, 2024

This documentation isn't complete, as the SAML feature isn't complete yet, but should be good enough to guide users that want to beta test it or for ourselves.

@cklim5

This comment was marked as spam.

Copy link
Member

@humitos humitos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks really good as a first step to me 馃憤馃徏

docs/user/guides/set-up-single-sign-on-saml.rst Outdated Show resolved Hide resolved
Comment on lines +71 to +72
By default, users that sign up with SAML do not have any permissions over any project.
However, you can define which teams users will auto-join when they sign up.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Aren't we creating a team automatically when SAML is enabled on an organization in a similar way as we are doing with Google SSO? If not, we should probably do the same and enable auto-join on that team. I think it's a good idea to keep consistency between these two SSO providers.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A team is automatically created.

Comment on lines +79 to +80
Existing users with email addresses from your configured domain will not be required to sign up using SAML,
but they won't be automatically joined to your organization.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there any way to enforce this in the next login after enabling SAML for the organization?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Similar to Google, we would need to find a way for users to link their existing account to the provider, but since we don't allow them so sign-in, they will be locked from their account. We could experiment with at least with some manual redirect to guide users to connect their accounts.

docs/user/guides/set-up-single-sign-on-saml.rst Outdated Show resolved Hide resolved
they may still have access to documentation pages until their session expires.
This is three days for the dashboard and documentation pages.

To completely revoke access to a user, remove them from all the teams they are part of.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I remember we talked about this a few times, but I'm not sure if we have an issue to track this. I think it's important to find a way of logout the users if they are revoked access. Do we have an issue for this that we can prioritize its research?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What we did last time was to decrease the session time, but it's impossible to know if a user access was revoked from the provider (unless we have a webhook of some kind). The other feature we are discussing is having a button to remove the user from all teams with a single click https://github.com/readthedocs/readthedocs-corporate/issues/1476.

@stsewd stsewd merged commit 58c74f0 into main May 20, 2024
7 checks passed
@stsewd stsewd deleted the basic-docs-for-saml branch May 20, 2024 17:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants