Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs: use EthicalAd implementation from addons #11318

Merged
merged 1 commit into from
May 21, 2024

Conversation

humitos
Copy link
Member

@humitos humitos commented May 8, 2024

Instead of injecting the EthicalAd in a customized way, we will injecting it by using the addons approach.

This will be a starting test before enabling this in all the projects that are using addons.

Requires:


馃摎 Documentation previews 馃摎

Instead of injecting the EthicalAd in a customized way,
we will injecting it by using the addons approach.

This will be a starting test before enabling this in all the projects that are
using addons.

Requires:
* readthedocs/addons#295
@humitos humitos requested a review from a team as a code owner May 8, 2024 16:55
@humitos humitos requested a review from agjohnson May 8, 2024 16:55
Copy link
Member

@ericholscher ericholscher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

馃煡

@humitos humitos merged commit 1eba2fb into main May 21, 2024
8 checks passed
@humitos humitos deleted the humitos/ethicalad-from-addons branch May 21, 2024 09:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants