Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix ExplicitInitRule correction #5296

Merged
merged 7 commits into from Oct 23, 2023
Merged

Fix ExplicitInitRule correction #5296

merged 7 commits into from Oct 23, 2023

Conversation

BB9z
Copy link
Contributor

@BB9z BB9z commented Oct 22, 2023 •
edited

fix #5289

The CI is having issues running now, you can verify it locally.

@BB9z BB9z changed the title [WIP] Fix #5289: ExplicitInitRule correction [WIP] Fix ExplicitInitRule correction Oct 22, 2023
@BB9z BB9z changed the title [WIP] Fix ExplicitInitRule correction Fix ExplicitInitRule correction Oct 22, 2023
@BB9z BB9z marked this pull request as ready for review October 22, 2023 03:03
@SwiftLintBot
Copy link

SwiftLintBot commented Oct 22, 2023 •
edited

17 Messages
📖 Linting Aerial with this PR took 1.18s vs 1.19s on main (0% faster)
📖 Linting Alamofire with this PR took 1.55s vs 1.55s on main (0% slower)
📖 Linting Brave with this PR took 8.83s vs 8.89s on main (0% faster)
📖 Linting DuckDuckGo with this PR took 4.44s vs 4.46s on main (0% faster)
📖 Linting Firefox with this PR took 10.32s vs 10.37s on main (0% faster)
📖 Linting Kickstarter with this PR took 10.86s vs 10.93s on main (0% faster)
📖 Linting Moya with this PR took 0.62s vs 0.62s on main (0% slower)
📖 Linting NetNewsWire with this PR took 3.25s vs 3.26s on main (0% faster)
📖 Linting Nimble with this PR took 0.83s vs 0.82s on main (1% slower)
📖 Linting PocketCasts with this PR took 8.64s vs 8.72s on main (0% faster)
📖 Linting Quick with this PR took 0.4s vs 0.4s on main (0% slower)
📖 Linting Realm with this PR took 11.62s vs 11.63s on main (0% faster)
📖 Linting Sourcery with this PR took 2.78s vs 2.8s on main (0% faster)
📖 Linting Swift with this PR took 5.22s vs 5.21s on main (0% slower)
📖 Linting VLC with this PR took 1.54s vs 1.54s on main (0% slower)
📖 Linting Wire with this PR took 19.37s vs 19.44s on main (0% faster)
📖 Linting WordPress with this PR took 13.13s vs 13.13s on main (0% slower)

Generated by 🚫 Danger

SimplyDanny
SimplyDanny reviewed Oct 22, 2023
View reviewed changes
Copy link
Collaborator

@SimplyDanny SimplyDanny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Looks good in general.

Tests/SwiftLintFrameworkTests/ExplicitInitRuleTests.swift Outdated Show resolved Hide resolved
Source/SwiftLintBuiltInRules/Rules/Idiomatic/ExplicitInitRule.swift Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
Tests/SwiftLintFrameworkTests/ExplicitInitRuleTests.swift Outdated Show resolved Hide resolved
@SimplyDanny SimplyDanny enabled auto-merge (squash) October 23, 2023 19:22
@SimplyDanny SimplyDanny merged commit cb3001b into realm:main Oct 23, 2023
11 checks passed
@BB9z BB9z deleted the fix/explicit-init-correction branch October 25, 2023 08:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SimplyDanny SimplyDanny SimplyDanny approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Autocorrect bug with Explicit Init rule
3 participants
@BB9z @SwiftLintBot @SimplyDanny