Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added viewIsAppearing in viewLifecycleMethodNames #5316

Merged
merged 5 commits into from Nov 1, 2023

Conversation

u-abyss
Copy link
Contributor

@u-abyss u-abyss commented Oct 31, 2023

Fix #5259

Added viewIsAppearing in viewLifecycleMethodNames.

@u-abyss u-abyss changed the title add: viewIsAppearing in viewLifecycleMethodNames Added viewIsAppearing in viewLifecycleMethodNames Oct 31, 2023
@SwiftLintBot
Copy link

SwiftLintBot commented Oct 31, 2023

18 Messages
📖 Linting Aerial with this PR took 1.18s vs 1.19s on main (0% faster)
📖 Linting Alamofire with this PR took 1.56s vs 1.56s on main (0% slower)
📖 Linting Brave with this PR took 8.9s vs 8.93s on main (0% faster)
📖 Linting DuckDuckGo with this PR took 4.48s vs 4.48s on main (0% slower)
📖 Linting Firefox with this PR took 10.42s vs 10.46s on main (0% faster)
📖 Linting Kickstarter with this PR took 10.94s vs 10.95s on main (0% faster)
📖 Linting Moya with this PR took 0.63s vs 0.63s on main (0% slower)
📖 Linting NetNewsWire with this PR took 3.27s vs 3.26s on main (0% slower)
📖 Linting Nimble with this PR took 0.82s vs 0.82s on main (0% slower)
📖 Linting PocketCasts with this PR took 8.72s vs 8.73s on main (0% faster)
📖 Linting Quick with this PR took 0.4s vs 0.4s on main (0% slower)
📖 Linting Realm with this PR took 11.7s vs 11.65s on main (0% slower)
📖 Linting Sourcery with this PR took 2.82s vs 2.81s on main (0% slower)
📖 Linting Swift with this PR took 5.24s vs 5.24s on main (0% slower)
📖 Linting VLC with this PR took 1.55s vs 1.55s on main (0% slower)
📖 Linting Wire with this PR took 19.53s vs 19.5s on main (0% slower)
📖 Linting WordPress with this PR took 13.19s vs 13.17s on main (0% slower)
📖 This PR fixed a violation in Firefox: /Client/Frontend/Fakespot/FakespotViewController.swift:132:14: warning: Type Contents Order Violation: An 'other_method' should not be placed amongst the type content(s) 'view_life_cycle_method' (type_contents_order)

Generated by 🚫 Danger

@marcelofabri
Copy link
Collaborator

Looks good! Can you please add an entry in the changelog as well?

@jpsim jpsim force-pushed the fix/support-viewisappearing branch from 15373d2 to acf8379 Compare November 1, 2023 12:28
@jpsim jpsim enabled auto-merge (squash) November 1, 2023 12:28
@jpsim
Copy link
Collaborator

jpsim commented Nov 1, 2023

Thanks @u-abyss this will merge once CI passes.

@jpsim jpsim merged commit 6dc4b86 into realm:main Nov 1, 2023
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

UIViewController viewIsAppearing is not supported by type_contents_order rule
4 participants