Realm Web: Basic structure and MongoDB Realm App types #2741
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Please rebase on |
|
|
kraenhansen
force-pushed
the
kh/mongodb-realm-app
branch
2 times, most recently
from
50a21c7
to
016d279
Compare
kraenhansen
force-pushed
the
kh/mongodb-realm-app
branch
from
016d279
to
2b39fc6
Compare
kraenhansen
force-pushed
the
kh/mongodb-realm-app
branch
from
4ac9125
to
15e5c2b
Compare
|
I continued working from #2762 - so I think this is ready to be reviewed (and merged). |
kneth
reviewed
Apr 3, 2020
blagoev
suggested changes
Apr 6, 2020
added 13 commits
April 16, 2020 23:40
kraenhansen
force-pushed
the
kh/mongodb-realm-app
branch
from
d592161
to
b18fc20
Compare
added 8 commits
April 17, 2020 00:46
blagoev
reviewed
Apr 21, 2020
blagoev
reviewed
Apr 21, 2020
kraenhansen
force-pushed
the
kh/mongodb-realm-app
branch
2 times, most recently
from
16796ab
to
5443902
Compare
kraenhansen
force-pushed
the
kh/mongodb-realm-app
branch
from
5443902
to
791523f
Compare
blagoev
reviewed
Apr 22, 2020
kraenhansen
changed the title
kneth
approved these changes
Apr 28, 2020
| /** | ||
| * Log out the currently authenticated user and clear any persisted authentication information. | ||
| */ | ||
| logOut(): Promise<void>; |
There was a problem hiding this comment.
Shouldn't logOut be on user only?
There was a problem hiding this comment.
Yeah - but I'll postpone that for phase 2, since this has already shipped before I learned about that change to the API.
| /** | ||
| * Pass an object implementing this interface to the app constructor. | ||
| */ | ||
| interface AppConfiguration { |
There was a problem hiding this comment.
We should also include name and version.
There was a problem hiding this comment.
Do you have a link to a description of those parameters? I didn't see them in any scopes but I do see them in the existing SDK.
There was a problem hiding this comment.
I've added this a as a task on phase 2.
blagoev
pushed a commit
that referenced
this pull request
May 5, 2020
* Adding realm-web and realm-web-integration * Improving iterating integration tests * Implemented UserState & refactored transports * Using app-importer and running tests from node.js * Fixed BaseTransport issue * Using explicit devDependencies * Renamed FF to FunctionsFactoryType * Renaming Credentials#material to Credentials#toJSON() * Renamed "fetcher" to "transport" * Fixed a typo * App constructor now takes string or configuration * Moved from tslint to eslint * Moved "realm-web-integration" to "realm-web-integration-tests" * Changed from targeting es5 to es6 * Removed unneeded dependencies on ts-mocha * Fixed a test * Adding symbolic links to the LICENSE * Updated tests of the app * Incorporated feedback from review * Refactored "UsernamePasswordCredentials" into "EmailPasswordCredentials" * Renamed "Credentials" directory to "credentials" * Updated package locks * Updates and exports the base and default functions factories * Removed automatically bootstrapping on postinstall * Re-implemented Credentials * Updated the functions factory types * Adding the header eslint plugin * Adding headers to sourcefiles in ./packages
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What, How & Why?
This closes the Realm Web part of #2699.
☑️ ToDos
Compatibilitylabel is updated or copied from previous entryBreakinglabel has been applied or is not necessaryIf this PR adds or changes public API's: