Adding more precise detection of Expo Go #6523
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kraenhansen
changed the title
kraenhansen
force-pushed
the
kh/expo-go-error
branch
from
77d4e67
to
c14a8f1
Compare
kraenhansen
added
the
no-jira-ticket
kraenhansen
force-pushed
the
kh/expo-go-error
branch
from
f175110
to
d4dc325
Compare
elle-j
approved these changes
Apr 10, 2024
|
|
||
| import { Platform } from "react-native"; | ||
|
|
||
| export function isExpoGo() { |
There was a problem hiding this comment.
Does it need to be exported?
Suggested change
| export function isExpoGo() { | |
| function isExpoGo() { |
|
Coverage test is still crashing (#6589) but that's not new - I'll go ahead and merge with it. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What, How & Why?
Many newcomers to Realm and Expo gets confused about the fact that Expo Go doesn't ship with native modules.
Instead of showing a generic error when failing to load our native module, I suggest adding an attempt to detect Expo Go and showing a more direct message, with actionable steps:
☑️ ToDos
Compatibilitylabel is updated or copied from previous entryCOMPATIBILITY.mdpackage.jsons (if updating internal packages)Breakinglabel has been applied or is not necessary