RJS-2792: Upgrade to Realm Core v14.5.0 #6598
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kraenhansen
added
the
no-jira-ticket
nirinchev
changed the title
nirinchev
removed
the
no-jira-ticket
kraenhansen
changed the title
kneth
reviewed
Apr 9, 2024
kneth
approved these changes
Apr 9, 2024
CHANGELOG.md
Outdated
| @@ -32,13 +32,17 @@ | |||
| * Fixed sorting order of strings to use standard unicode codepoint order instead of grouping similar English letters together. A noticeable change will be from "aAbBzZ" to "ABZabz". ([realm/realm-core#2573](https://github.com/realm/realm-core/issues/2573)) | |||
| * `data` and `string` are now strongly typed for comparisons and queries. This change is especially relevant when querying for a string constant on a Mixed property, as now only strings will be returned. If searching for `data` is desired, then that type must be specified by the constant. In RQL the new way to specify a binary constant is to use `mixed = bin('xyz')` or `mixed = binary('xyz')`. ([realm/realm-core#6407](https://github.com/realm/realm-core/issues/6407)) | |||
|
|
|||
| * Fixed diverging history due to a bug in the replication code when setting default null values (embedded objects included) ([realm/realm-core#7536](https://github.com/realm/realm-core/issues/7536)). | |||
| * Null pointer exception may be triggered when logging out and async commits callbacks not executed ([realm/realm-core#7434](https://github.com/realm/realm-core/issues/7434), since v12.6.0) | |||
|
|
|||
| ### Compatibility | |||
| * React Native >= v0.71.4 | |||
| * Realm Studio v15.0.0. | |||
| * File format: generates Realms with format v24 (reads and upgrades file format v10 or later). | |||
|
|
|||
| ### Internal | |||
| * Upgraded Realm Core from v13.26.0 to v14.4.1. ([#6499](https://github.com/realm/realm-js/issues/6499), [#6541](https://github.com/realm/realm-js/issues/6541), [#6568](https://github.com/realm/realm-js/issues/6568), and [#6572](https://github.com/realm/realm-js/issues/6572)) | |||
There was a problem hiding this comment.
Suggested change
| * Upgraded Realm Core from v13.26.0 to v14.4.1. ([#6499](https://github.com/realm/realm-js/issues/6499), [#6541](https://github.com/realm/realm-js/issues/6541), [#6568](https://github.com/realm/realm-js/issues/6568), and [#6572](https://github.com/realm/realm-js/issues/6572)) | |
| * Upgraded Realm Core from v13.26.0 to v14.5.0. ([#6499](https://github.com/realm/realm-js/issues/6499), [#6541](https://github.com/realm/realm-js/issues/6541), [#6568](https://github.com/realm/realm-js/issues/6568), [#6572](https://github.com/realm/realm-js/issues/6572), and [#6599](https://github.com/realm/realm-js/issues/6599)) |
elle-j
approved these changes
Apr 9, 2024
CHANGELOG.md
Outdated
| ### Compatibility | ||
| * React Native >= v0.71.4 | ||
| * Realm Studio v15.0.0. | ||
| * File format: generates Realms with format v24 (reads and upgrades file format v10 or later). | ||
|
|
||
| ### Internal | ||
| * Upgraded Realm Core from v13.26.0 to v14.4.1. ([#6499](https://github.com/realm/realm-js/issues/6499), [#6541](https://github.com/realm/realm-js/issues/6541), [#6568](https://github.com/realm/realm-js/issues/6568), and [#6572](https://github.com/realm/realm-js/issues/6572)) | ||
| * The base URL used to communicate with the Atlas App Services was updated changed from "https://realm.mongodb.com" to "https://services.cloud.mongodb.com". ([realm/realm-core#7534](https://github.com/realm/realm-core/pull/7534)). |
There was a problem hiding this comment.
Suggested change
| * The base URL used to communicate with the Atlas App Services was updated changed from "https://realm.mongodb.com" to "https://services.cloud.mongodb.com". ([realm/realm-core#7534](https://github.com/realm/realm-core/pull/7534)). | |
| * The base URL used to communicate with the Atlas App Services was changed from "https://realm.mongodb.com" to "https://services.cloud.mongodb.com". ([realm/realm-core#7534](https://github.com/realm/realm-core/pull/7534)). |
There was a problem hiding this comment.
What do you think about making the file name less coupled to the tool used? So just formatter.ts. Possibly the exported variable as well?
There was a problem hiding this comment.
We could merge the trunk-formatter.ts with the eslint-formatter.ts? 🤔 Into a formatters.ts.
It feels relevant to me that the code requesting the formatting (the binding template) is explicit in which tool it expects to handle the formatting, so simply naming it "cpp-formatter" or something similar feels a bit wrong to me 🤔 What do you think would be the pros / cons here?
There was a problem hiding this comment.
I ended up turning this into a return assert.fail(...) instead 👍
There was a problem hiding this comment.
Was thinking that we only had one formatter now but yeah we have the eslint as well. Sounds reasonable to merge the files though so that they're grouped under "formatters".
kraenhansen
force-pushed
the
kh/realm-core-14.5.0
branch
from
bb64dd0
to
8223927
Compare
Co-authored-by: LJ <81748770+elle-j@users.noreply.github.com> Co-authored-by: Kenneth Geisshirt <kenneth.geisshirt@mongodb.com>
kraenhansen
force-pushed
the
kh/realm-core-14.5.0
branch
from
cbd8778
to
8223dab
Compare
|
Coverage test is still crashing (#6589) but that's not new - I'll go ahead and merge with it. |
This was referenced Apr 10, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What, How & Why?
This upgrades to Realm Core v14.5.0.
In alignment with realm/realm-core#7554 this removes the root package's dependency on
clang-format.Fixes #6544
☑️ ToDos
Compatibilitylabel is updated or copied from previous entryCOMPATIBILITY.mdpackage.jsons (if updating internal packages)Breakinglabel has been applied or is not necessary