Fix performance tests #6665
Merged
Fix performance tests #6665
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elle-j
added
no-changelog
no-jira-ticket
elle-j
commented
May 13, 2024
| } | ||
| } else { | ||
| return type; | ||
| const COLLECTION_MARKERS: Readonly<Record<string, string>> = { |
There was a problem hiding this comment.
Widening the type here for better ergonomics when bracket accessing it by an unknown string (and that's the only way it's used in this file).
elle-j
commented
May 13, 2024
| * "int?[]" -> "int?[]" | ||
| * { type: "list", objectType: "int", optional: true } -> "int?[]" | ||
| */ | ||
| function getTypeDisplayName(schema: PropertySchemaShorthand | PropertySchema) { |
There was a problem hiding this comment.
Renaming from getTypeName to disambiguate it from the various usages of type we have.
kneth
approved these changes
May 22, 2024
kraenhansen
approved these changes
May 23, 2024
papafe
added a commit
that referenced
this pull request
May 23, 2024
* main: (22 commits) Prepare for vNext (#6677) [12.9.0] Bump version (#6676) Fix performance tests (#6665) Combined: Support `Mixed` data type with collections (#6613) Update expected error messages (#6674) Adding --latest-local to the baas test server CLI (#6673) Upgrade to Realm Core v14.7.0 (#6663) Upgrade @trunk/launcher to v1.3.1 to support Apple's versioning scheme for macOS (#6671) Prepare for vNext (#6669) [12.8.1] Bump version (#6668) Use unreleased core (#6667) Fix realm/react changelog (#6661) Fix GHA error when publishing package release (#6660) Prepend vNext to realm/react changelog. [realm-react-0.7.0] Bump version (#6658) Update OAuth2Helper to remove accessing the stitch prefix (#6659) Fix unresolvable links in API reference docs and remove re-exports (#6646) Prepare for vNext (#6645) [12.8.0] Bump version (#6643) Upgrade to HEAD of Realm Core's master (#6637) ... # Conflicts: # CHANGELOG.md # integration-tests/tests/src/tests/mixed.ts
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What, How & Why?
Fixes the broken performance tests and makes the type outputs from the tests consistent (no matter how you pass in the property schema).