Make MDX compatible with 4.14 #356
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Nathan Rebours <nathan.p.rebours@gmail.com>
There was a problem hiding this comment.
Thanks for the PR! The changes are overall quite minor indeed but of course the difficult part is to figure out how to do stuff in 4.14 and not writing down the LoC 👍 I have one comment, that would make it possible to potentially simplify the code a tiny bit.
Leonidas-from-XIV
approved these changes
Nov 29, 2021
Leonidas-from-XIV
added a commit
to Leonidas-from-XIV/opam-repository
that referenced
this pull request
Dec 8, 2021
CHANGES: #### Added - Make MDX compatible with OCaml 4.14 (realworldocaml/mdx#356, @NathanReb)
RadioPotin
pushed a commit
to RadioPotin/opam-repository
that referenced
this pull request
Dec 9, 2021
CHANGES: #### Added - Make MDX compatible with OCaml 4.14 (realworldocaml/mdx#356, @NathanReb)
Leonidas-from-XIV
added a commit
to Leonidas-from-XIV/opam-repository
that referenced
this pull request
Dec 14, 2021
CHANGES: #### Added - Add trailing `;;` to the output of toplevel phrases that were missing it. (realworldocaml/mdx#346, @Leonidas-from-XIV) - Make MDX compatible with OCaml 4.14 (realworldocaml/mdx#356, @NathanReb) #### Fixed - Use the same output as the normal toplevel. Mdx used to carry an unsafe patch to work around a bug fixed in OCaml 4.06 and that patch would change the printed types in some corner cases. (realworldocaml/mdx#322, @emillon) #### Removed - Dropped compatibility with older OCaml versions. The minimal supported range is 4.08 to 4.13 now (realworldocaml/mdx#345, @Leonidas-from-XIV) - Do not install deprecated `mdx` binary anymore (realworldocaml/mdx#274, @gpetiot) - Remove deprecated `rule` command (realworldocaml/mdx#312, @gpetiot) - Remove support for `require-package` label, use the `mdx` stanza in dune instead. This label was only used for the `rule` command and can now be safely removed. (realworldocaml/mdx#363, @Leonidas-from-XIV)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not much to note here, some changes in the typing API, all pretty straight forward (see the upstream PR ocaml/ocaml#10337) and the new
Shape.treturned bytype_structurewhich we can simply ignore as @voodoos confirmed it's not really relevant to MDX!