fix: pie label keys are not unique #4224
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Going to merge, minor change |
renovate bot
added a commit
to SAP/ui5-webcomponents-react
that referenced
this pull request
Mar 1, 2024
[](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [recharts](https://togithub.com/recharts/recharts) | [`2.12.1` -> `2.12.2`](https://renovatebot.com/diffs/npm/recharts/2.12.1/2.12.2) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>recharts/recharts (recharts)</summary> ### [`v2.12.2`](https://togithub.com/recharts/recharts/releases/tag/v2.12.2) [Compare Source](https://togithub.com/recharts/recharts/compare/v2.12.1...v2.12.2) #### What's Changed Some more small fixes while working on 3.x ##### Fix - `Pie`: pie label keys are not unique when data is 0 by [@​ckifer](https://togithub.com/ckifer) in [recharts/recharts#4224 - `ResponsiveContainer`: Remove incorrectly timed console.warn call, only log when using soon-to-be deprecated feature by [@​HHongSeungWoo](https://togithub.com/HHongSeungWoo) in [recharts/recharts#4249 **Full Changelog**: recharts/recharts@v2.12.1...v2.12.2 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/SAP/ui5-webcomponents-react). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4yMjAuMiIsInVwZGF0ZWRJblZlciI6IjM3LjIyMC4yIiwidGFyZ2V0QnJhbmNoIjoibWFpbiJ9--> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
](https://renovatebot.com){kind=link}
This was referenced May 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
continue to undo key changes... 🙃
Related Issue
#4219
Motivation and Context
errors thrown when data is duplicated or when 0 is used as a datapoint
How Has This Been Tested?
use 0 as a datapoint and dont log a unique key error
Screenshots (if appropriate):
Types of changes
Checklist: