Remove role attribute from recharts-wrapper #4386
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ckifer
approved these changes
Apr 3, 2024
|
thank you |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## 3.x #4386 +/- ##
==========================================
- Coverage 95.06% 95.06% -0.01%
==========================================
Files 96 96
Lines 20616 20615 -1
Branches 2830 2829 -1
==========================================
- Hits 19599 19598 -1
Misses 1011 1011
Partials 6 6 ☔ View full report in Codecov by Sentry. |
ckifer
pushed a commit
that referenced
this pull request
Apr 3, 2024
<!--- Provide a general summary of your changes in the Title above --> <!--- Describe your changes in detail --> Before this PR, there was a `role` attribute on both the `.recharts-wrapper` parent DIV, as well as the SVG element. This is unnecessary, since the SVG element is enough. That extra role also caused problems, as I outlined in #4384 This PR removes the `role` attribute from the `.recharts-wrapper` element. The SVG element still retains its role. <!--- This project only accepts pull requests related to open issues --> <!--- If suggesting a new feature or change, please discuss it in an issue first --> <!--- If fixing a bug, there should be an issue describing it with steps to reproduce --> <!--- Please link to the issue here: --> #4384 <!--- Why is this change required? What problem does it solve? --> <!--- Please describe in detail how you tested your changes. --> <!--- Include details of your testing environment, and the tests you ran to --> <!--- see how your change affects other areas of the code, etc. --> <!--- What types of changes does your code introduce? Put an `x` in all the boxes that apply: --> - [x] Bug fix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds functionality) - [ ] Breaking change (fix or feature that would cause existing functionality to change) <!--- Go over all the following points, and put an `x` in all the boxes that apply. --> <!--- If you're unsure about any of these, don't hesitate to ask. We're here to help! --> - [ ] My change requires a change to the documentation. - [ ] I have updated the documentation accordingly. - [ ] I have added tests to cover my changes. - [ ] I have added a storybook story or extended an existing story to show my changes
renovate bot
added a commit
to SAP/ui5-webcomponents-react
that referenced
this pull request
Apr 8, 2024
[](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [recharts](https://togithub.com/recharts/recharts) | [`2.12.3` -> `2.12.4`](https://renovatebot.com/diffs/npm/recharts/2.12.3/2.12.4) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>recharts/recharts (recharts)</summary> ### [`v2.12.4`](https://togithub.com/recharts/recharts/releases/tag/v2.12.4) [Compare Source](https://togithub.com/recharts/recharts/compare/v2.12.3...v2.12.4) #### What's Changed Small fixes while working on v3 continued... ##### Fix - `Accessibility`: remove role attribute from recharts-wrapper which caused an accessibility violation with > 1 chart on the same page by [@​julianna-langston](https://togithub.com/julianna-langston) in [recharts/recharts#4386, fixes [#​4384](https://togithub.com/recharts/recharts/issues/4384) - `X/YAxis`: fix incorrect padding calculation when there is 1 datapoint or less by [@​graup](https://togithub.com/graup) in [recharts/recharts#4314 closes [#​4313](https://togithub.com/recharts/recharts/issues/4313) `className` fixes - helps slowly address [recharts/recharts#2169: - `Tooltip`: allow custom `className` on `cursor` by [@​108yen](https://togithub.com/108yen) in [recharts/recharts#4306 - `RadarChart/RadialBarChart`: allow custom `className` on `PolarRadiusAxis`, `PolarAngleAxis`, and `Radar` dot by [@​108yen](https://togithub.com/108yen) in [recharts/recharts#4335 - `Pie`: allow custom `className` on `label` and `labelLine` of `Pie` by [@​108yen](https://togithub.com/108yen) in [recharts/recharts#4381 **Full Changelog**: recharts/recharts@v2.12.3...v2.12.4 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/SAP/ui5-webcomponents-react). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4yNjkuMiIsInVwZGF0ZWRJblZlciI6IjM3LjI2OS4yIiwidGFyZ2V0QnJhbmNoIjoibWFpbiJ9--> --------- Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: Lukas Harbarth <lukas.harbarth@sap.com>
This was referenced May 23, 2024
](https://renovatebot.com){kind=link}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Before this PR, there was a
roleattribute on both the.recharts-wrapperparent DIV, as well as the SVG element. This is unnecessary, since the SVG element is enough. That extra role also caused problems, as I outlined in #4384This PR removes the
roleattribute from the.recharts-wrapperelement. The SVG element still retains its role.Related Issue
#4384
Motivation and Context
How Has This Been Tested?
Screenshots (if appropriate):
Types of changes
Checklist: