Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

types: add some types to generateCategoricalChart #4535

Merged
merged 1 commit into from
May 16, 2024
Merged

Conversation

ckifer
Copy link
Member

@ckifer ckifer commented May 16, 2024

Description

silly PR with a few type additions in the generate function

Related Issue

Motivation and Context

I can't do anything else helpful!

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • I have added a storybook story or extended an existing story to show my changes

@ckifer ckifer requested a review from PavelVanecek May 16, 2024 05:32
Copy link

codecov bot commented May 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.56%. Comparing base (85b29df) to head (002217b).

Additional details and impacted files
@@           Coverage Diff           @@
##              3.x    #4535   +/-   ##
=======================================
  Coverage   95.55%   95.56%           
=======================================
  Files         116      116           
  Lines       22220    22230   +10     
  Branches     3057     3057           
=======================================
+ Hits        21233    21243   +10     
  Misses        981      981           
  Partials        6        6           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@PavelVanecek PavelVanecek merged commit 9e8f254 into 3.x May 16, 2024
11 checks passed
@ckifer ckifer deleted the add-more-types branch May 16, 2024 14:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants