-
-
Notifications
You must be signed in to change notification settings - Fork 360
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[CodingStyle] Skip non-empty-string on VarConstantCommentRector #2451
Conversation
Fixed 🎉 /cc @internalsystemerror |
8abac3c
to
3326934
Compare
@samsonasik Damn that was fast! Thank you! |
fc6d02a
to
96ed6e6
Compare
02a4a55
to
0253e9f
Compare
All checks have passed 🎉 @TomasVotruba it is ready for review. |
@@ -92,6 +96,10 @@ public function refactor(Node $node): ?Node | |||
return null; | |||
} | |||
|
|||
if ($this->shouldSkipStringType($phpDocInfo, $node->consts[0]->value)) { | |||
return null; | |||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should be handled in string type mapper.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ok, it previous got @param non-empty-string $expectedName
removed on used by other rule, I will check more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
updated to check on IdentifierTypeMapper aee64c7
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
checking in IdentifierTypeMapper
seems cause removal of @param
again:
- /**
- * @param non-empty-string $function
- * @param non-empty-string $class
- * @param non-empty-string $arrayMethod
- * @param non-empty-string $nonArrayMethod
- */
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's try register AccessoryNonEmptyStringType
into ScalarStringToTypeMapper
831a7e3
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it works 🎉
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you, that seems the best place 👍
0253e9f
to
aee64c7
Compare
2168d3a
to
831a7e3
Compare
All checks have passed 🎉 @TomasVotruba I think it is ready. |
Fixes rectorphp/rector#7214