Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Php81] Skip param reassign on ReadOnlyPropertyRector #2498

Merged
merged 5 commits into from
Jun 17, 2022

Conversation

samsonasik
Copy link
Member

@samsonasik samsonasik requested a review from TomasVotruba as a code owner June 16, 2022 09:36
@samsonasik
Copy link
Member Author

Fixed 🎉 /cc @OskarStark

@samsonasik
Copy link
Member Author

All checks have passed 🎉 @TomasVotruba it is ready for review.

@OskarStark
Copy link
Contributor

Thanks 🙏

Cc @mvhirsch

@OskarStark
Copy link
Contributor

Cc @silasjoisten

@samsonasik samsonasik force-pushed the skip-param-reassign branch from 73caa5b to dab85f2 Compare June 16, 2022 14:19
@samsonasik
Copy link
Member Author

rebased.

@samsonasik samsonasik force-pushed the skip-param-reassign branch from d758581 to 5c71111 Compare June 16, 2022 15:36
@samsonasik
Copy link
Member Author

rebased.

samsonasik and others added 5 commits June 17, 2022 13:27

Verified

This commit was signed with the committer’s verified signature.
samsonasik Abdul Malik Ikhsan

Verified

This commit was signed with the committer’s verified signature.
samsonasik Abdul Malik Ikhsan

Verified

This commit was signed with the committer’s verified signature.
samsonasik Abdul Malik Ikhsan

Verified

This commit was signed with the committer’s verified signature.
samsonasik Abdul Malik Ikhsan

Verified

This commit was signed with the committer’s verified signature.
samsonasik Abdul Malik Ikhsan
@samsonasik samsonasik force-pushed the skip-param-reassign branch from 5c71111 to f8eb47f Compare June 17, 2022 06:27
@samsonasik
Copy link
Member Author

rebased.

@TomasVotruba TomasVotruba merged commit 064d38b into main Jun 17, 2022
@TomasVotruba TomasVotruba deleted the skip-param-reassign branch June 17, 2022 07:17
@OskarStark
Copy link
Contributor

Thanks for the merge, now it does not make an error, but it does not refactor it to use readonly, which can only be done by adding an explicit readonly class property.

WDYT @TomasVotruba ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Incorrect behavior of ReadOnlyPropertyRector
4 participants