Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove deprecated @noRector warning #3518

Merged
merged 1 commit into from
Mar 25, 2023
Merged

Conversation

samsonasik
Copy link
Member

It's been a while, I think @noRector warning can be removed.

Partially verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
We cannot verify signatures from co-authors, and some of the co-authors attributed to this commit require their commits to be signed.
@samsonasik
Copy link
Member Author

Github seems down now: https://www.githubstatus.com/

Raw url on vendor patches seems just got error:

https://github.com/rectorphp/rector-src/actions/runs/4515258029/jobs/7952332086?pr=3518#step:4:341

this is unrelated with this PR.

@samsonasik samsonasik closed this Mar 24, 2023
@samsonasik samsonasik reopened this Mar 24, 2023
@samsonasik
Copy link
Member Author

Close-Reopen to restart build

@samsonasik
Copy link
Member Author

All checks have passed 🎉 @TomasVotruba it is ready for review.

@TomasVotruba TomasVotruba merged commit 3445422 into main Mar 25, 2023
@TomasVotruba TomasVotruba deleted the remove-deprecate-no-rector branch March 25, 2023 11:15
@TomasVotruba
Copy link
Member

Thanks 👍

samsonasik added a commit that referenced this pull request May 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants