Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CodingStyle] Remove next node attribute on NewlineAfterStatementRector #3525

Merged
merged 11 commits into from
Mar 27, 2023

Conversation

samsonasik
Copy link
Member

@samsonasik samsonasik commented Mar 26, 2023

This remove AttributeKey::NEXT_NODE usage on NewlineAfterStatementRector,

Benefit

Limitation

  • this no longer work on spacing new line for multiple namespaces,eg:
namespace A{}
namespace B{}

as there is no parent of namespace to loop, see https://github.com/rectorphp/rector-src/pull/3525/files#diff-6169f918307ebebbb7127ccd6c653513c3269acb124e30add820d370fe3a0eac

Ref rectorphp/rector#7849

Partially verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
We cannot verify signatures from co-authors, and some of the co-authors attributed to this commit require their commits to be signed.
@samsonasik samsonasik marked this pull request as draft March 26, 2023 18:52
@samsonasik samsonasik force-pushed the remove-next-node-newline branch from 17533e4 to 97e96d5 Compare March 26, 2023 19:22
@samsonasik samsonasik marked this pull request as ready for review March 26, 2023 19:27
@samsonasik
Copy link
Member Author

All checks have passed 🎉 @TomasVotruba it is ready for review.

@TomasVotruba TomasVotruba merged commit ae2355d into main Mar 27, 2023
@TomasVotruba TomasVotruba deleted the remove-next-node-newline branch March 27, 2023 07:28
@TomasVotruba
Copy link
Member

Thank you 👏 👏 👏

samsonasik added a commit that referenced this pull request May 8, 2023
…or (#3525)

Co-authored-by: GitHub Action <actions@github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants