Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[PostRector] Skip remove unused use on used as ConstFetchNode, eg: TypeKind::* #3560

Merged
merged 5 commits into from
Apr 4, 2023
Merged

[PostRector] Skip remove unused use on used as ConstFetchNode, eg: TypeKind::* #3560

merged 5 commits into from
Apr 4, 2023
+48 −0

Conversation

samsonasik
Copy link
Member

The following code should be skipped from removal from unused use.

use Rector\PHPStanStaticTypeMapper\Enum\TypeKind;

final class SkipUsedWithAsterisk
{
    /**
     * @param TypeKind::* $typeKind
     */
    public function run(string $typeKind)
    {
    }
}

@samsonasik
[PostRector] Skip remove unused use on used as asterisk

Partially verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
We cannot verify signatures from co-authors, and some of the co-authors attributed to this commit require their commits to be signed.
ef78bac
@samsonasik samsonasik requested a review from TomasVotruba as a code owner April 3, 2023 19:48
@samsonasik
Copy link
Member Author

Fixed 🎉

@samsonasik samsonasik changed the title [PostRector] Skip remove unused use on used as asterisk [PostRector] Skip remove unused use on used as ConstFetchNode, eg: TypeKind::* Apr 3, 2023
@samsonasik
Copy link
Member Author

All checks have passed 🎉 @TomasVotruba I think it is ready.

@samsonasik
Copy link
Member Author

@TomasVotruba I am merging it ;)

@samsonasik samsonasik merged commit 1da2282 into main Apr 4, 2023
@samsonasik samsonasik deleted the skip-rem-asterisk branch April 4, 2023 00:53
samsonasik added a commit that referenced this pull request May 8, 2023
@samsonasik
[PostRector] Skip remove unused use on used as ConstFetchNode, eg: Ty…
3f564bc 
…peKind::* (#3560)

* [PostRector] Skip remove unused use on used as asterisk

* Fixed 🎉

* final touch: eol

* final touch: rename fixture

* rename method
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TomasVotruba TomasVotruba

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@samsonasik