Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump to PHPStan 1.11 #5883

Merged
merged 2 commits into from
May 18, 2024
Merged

Bump to PHPStan 1.11 #5883

merged 2 commits into from
May 18, 2024

Conversation

TomasVotruba
Copy link
Member

No description provided.

@TomasVotruba TomasVotruba changed the title bump to PHPStan 11 Bump to PHPStan 11 May 15, 2024
@samsonasik
Copy link
Member

samsonasik commented May 16, 2024

PHPStan has notice,

Run vendor/bin/phpstan analyse --ansi --error-format symplify
Note: Using configuration file /home/runner/work/rector-src/rector-src/phpstan.neon.
⚠️  You're using a deprecated config option checkGenericClassInNonGenericObjectType ⚠️️

It's strongly recommended to remove it from your configuration file
and add the missing generic typehints.

If you want to continue ignoring missing typehints from generics,
add missingType.generics error identifier to your ignoreErrors:

parameters:
	ignoreErrors:
		-
			identifier: missingType.generics

The config needs to be updated, like this:

https://github.com/codeigniter4/CodeIgniter4/blob/f927928aaf42a0646301c629887d86ee913f84f2/phpstan.neon.dist#L34-L36

see example PR:

@samsonasik
Copy link
Member

PR title need to be changed to PHPStan 1.11 instead of PHPStan 11

@samsonasik
Copy link
Member

samsonasik commented May 16, 2024

I created separate PR to fix PHPStan notice on PHPStan 1.11:

@TomasVotruba TomasVotruba changed the title Bump to PHPStan 11 Bump to PHPStan 1.11 May 18, 2024
@samsonasik
Copy link
Member

Let's give it a try, thank you @TomasVotruba

@samsonasik samsonasik merged commit 8e4e882 into main May 18, 2024
42 checks passed
@samsonasik samsonasik deleted the tv-phpstan-11 branch May 18, 2024 07:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants