[PHPStan 1.11] Init PHPStanServicesFactory to load PHPStan ContainerFactory() early on LazyContainerFactory

[samsonasik]

Real Fixes rectorphp/rector#8641

@simonschaufi based on @ondrejmirtes suggestion on rectorphp/rector#8641 (comment) , it seems on PHPStan 1.11, the PHPStan ContainerFactory need to be loaded early so :

TypeCombinator::addNull()

can be used in the rector config.

Before (Internal error.)

➜  typo3-rector git:(bb) vendor/bin/rector process src/Helper --config templates/rector.php --dry-run --ansi --clear-cache

                                                                                                                        
 [ERROR] Internal error.                                                                                                                                                                                                                  

After (working ok)

➜  typo3-rector git:(bb) vendor/bin/rector process src/Helper --config templates/rector.php --dry-run --ansi --clear-cache
 4/4 [▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓] 100%

                                                                                                                        
 [OK] Rector is done!                                                                                      

[samsonasik]

Hm.., it strange that when I create e2e test, it show diff when using UnionType, but not show the diff when using TypeCombinator

With TypeCombinator

➜  type-combinator-in-config git:(phpstan-service-factory-init) ✗ php ../e2eTestRunner.php 
 3/3 [▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓] 100%[OK] Rector is done!%  

With UnionType

➜  type-combinator-in-config git:(phpstan-service-factory-init) ✗ php ../e2eTestRunner.php
 3/3 [▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓] 100%1 file with changes
===================

1) src/NullWithObjectType.php:3

    ---------- begin diff ----------
@@ @@

 class NullWithObjectType implements FolderInterface
 {
-    public function create(string $fileName)
+    public function create(string $fileName): ?\App\FileInterface
     {

     }
    ----------- end diff -----------

Applied rules:
 * AddReturnTypeDeclarationRector


 [OK] 1 file would have changed (dry-run) by Rector%  

[samsonasik]

I added e2e test for it 2aebf23

[samsonasik]

It seems due to overlapped config, and it loaded later, but because the rector config (cache path, etc) need to be loaded before it, it can't be flipped.

It seems using UnionType is the way to go for now.

Closing for now.

[simonschaufi]

Thank you for your attempt to fix it.