Adding trash operations at scale #3556
Conversation
manasagowri
force-pushed
the
trash_scale
branch
from
08e7456
to
18f2252
Compare
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: manasagowri, sunilangadi2 The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
|
||
| trash_list = json.loads(out) | ||
| image_id = [ | ||
| trash_image.get("id") |
There was a problem hiding this comment.
Please add NoneType check for trash_image.get("id"), otherwise image_id list may end up in NoneTypes.
There was a problem hiding this comment.
If there is an image, there will definitely be an ID. So I think we don't need a nonetype check here. Please let me know if you still think otherwise.
| log.info( | ||
| f"Creating snaps and clones for every alternate image in the pool {pool}" | ||
| ) | ||
| rc = wrapper_for_image_ops( |
There was a problem hiding this comment.
md5sum validations for snap_clone operations makes this complete
There was a problem hiding this comment.
Sure will add this as part of my next partial PR for this. Hope that's okay
| log.info( | ||
| f"Restore images from trash, create new images and verify for pool {pool}" | ||
| ) | ||
| rc = restore_and_create_new_image( |
There was a problem hiding this comment.
after restoring images from trash, IMHO we should do md5sum check of restored images to prior to trash images and perform IO on restored image to make sure its usable after restore.
There was a problem hiding this comment.
Sure will add this as part of my next partial PR for this. Hope that's okay
|
This Pull request has been automatically marked as STALE due to inactivity for 15 days and will be CLOSED on further inactivity on the PR for another 15 days. |
Signed-off-by: manasagowri <manasagowri16@gmail.com>
|
This Pull request has been automatically marked as STALE due to inactivity for 15 days and will be CLOSED on further inactivity on the PR for another 15 days. |
|
"This pull request now has conflicts with the target branch. Could you please resolve conflicts and force push the corrected changes?" |
|
PR needs rebase. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
This Pull request has been automatically marked as STALE due to inactivity for 15 days and will be CLOSED on further inactivity on the PR for another 15 days. |
Adding trash operations at scale. Automating test case - CEPH-83582444
Automated only a part of the above polarion test case in this PR since it is a pretty big change.
The steps automated for this are
Success Logs
Sequential execution - http://magna002.ceph.redhat.com/cephci-jenkins/cephci-run-M9F1I4/
Parallel execution - http://magna002.ceph.redhat.com/cephci-jenkins/cephci-run-E5GA9C/