[Test] Add host to maintenance using flags #3678

sayaleeraut · 2024-05-09T05:02:06Z

Description

Please include Automation development guidelines. Source of Test case - New Feature/Regression Test/Close loop of customer BZs

click to expand checklist

Create a test case in Polarion reviewed and approved.
Create a design/automation approach doc. Optional for tests with similar tests already automated.
Review the automation design
Implement the test script and perform test runs
Submit PR for code review and approve
Update Polarion Test with Automation script details and update automation fields
If automation is part of Close loop, update BZ flag qe-test_coverage “+” and link Polarion test

openshift-ci · 2024-05-09T05:02:12Z

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: sayaleeraut

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

sayaleeraut · 2024-05-09T06:51:29Z

Tox results -

===================================================================== 17 passed, 3 warnings in 0.69s ======================================================================
py3: commands[1]> flake8
py3: commands[2]> isort -c .
Skipped 3 files
py3: commands[3]> black --check --diff .
All done! ✨ 🍰 ✨
1045 files would be left unchanged.
py3: commands[4]> yamllint -d relaxed --no-warnings .
.pkg: _exit> python /Library/Frameworks/Python.framework/Versions/3.11/lib/python3.11/site-packages/pyproject_api/_backend.py True setuptools.build_meta legacy
py3: OK (25.29=setup[4.25]+cmd[0.87,1.50,1.46,3.00,14.21] seconds)
congratulations :) (25.33 seconds)

tests/cephadm/test_add_host_to_maintenance_using_flags.py

vamahaja · 2024-05-09T08:26:28Z

suites/reef/cephadm/tier-2-add-host-into-maintenance-using-flags.yaml

@@ -0,0 +1,90 @@
+#===============================================================================================
+#-------------------------------------
+#-----    Smoke Test suite     ------


Smoke test suite ?

vamahaja · 2024-05-09T08:26:34Z

suites/reef/cephadm/tier-2-add-host-into-maintenance-using-flags.yaml

+#-------------------------------------
+#-----    Smoke Test suite     ------
+#-------------------------------------
+# Conf: conf/quincy/cephadm/tier-0.yaml


vamahaja · 2024-05-09T08:27:39Z

suites/reef/cephadm/tier-2-add-host-into-maintenance-using-flags.yaml

+      name: configure client
+
+  # Testing stage
+  - test:


Do we need separate cluster for this operation? Can't it added to any existing suite ?

Okay, will add it to suites/reef/cephadm/tier0-cephadm.yaml

vamahaja · 2024-05-09T08:28:48Z

tests/cephadm/test_add_host_to_maintenance_using_flags.py

+
+    # Put the host into maintainence
+    cmd = f"ceph orch host maintenance enter {instance_name} --force --yes-i-really-mean-it"
+    out = cephadm.shell([cmd])


Why cephadm.shell? Add libraries for same operation

Hey @vamahaja Using this "--yes-i-really-mean-it" flag we are forcing a host into maintenance and it not a recommended way to do it.
Not sure if it will be used in other test scenarios, please let me know if still this needs to converted to a lib.

vamahaja · 2024-05-09T08:28:59Z

tests/cephadm/test_add_host_to_maintenance_using_flags.py

+        )
+
+    # Validate Cephadm logs for no OrchestratorError
+    cmd = "ceph log last 3 cephadm"


same as above

sayaleeraut · 2024-05-22T10:09:17Z

Tox results -

py3: commands[1]> flake8
py3: commands[2]> isort -c .
Skipped 3 files
py3: commands[3]> black --check --diff .
All done! ✨ 🍰 ✨
1047 files would be left unchanged.
py3: commands[4]> yamllint -d relaxed --no-warnings .
.pkg: _exit> python /Library/Frameworks/Python.framework/Versions/3.11/lib/python3.11/site-packages/pyproject_api/_backend.py True setuptools.build_meta legacy
py3: OK (23.67=setup[3.88]+cmd[0.51,1.45,1.30,2.74,13.79] seconds)
congratulations :) (23.70 seconds)

Signed-off-by: “sayalee” <saraut@redhat.com>

vamahaja · 2024-05-23T12:06:19Z

cli/ceph/orch/host.py

+            force (bool): Whether to append force with maintenance enter command
+            yes-i-really-mean-it (bool) : Whether to append --yes-i-really-mean-it with maintenance enter command
+        """
+        if operation == "enter":


Use cmd = f"{self.base_cmd} maintenance {operation} {hostname}

vamahaja · 2024-05-23T12:07:23Z

cli/ceph/orch/host.py

+            operation(str): enter/exit maintenance mode
+            kw (dict): Key/value pairs that needs to be provided to the installer
+
+        Supported keys:


**kw is used for large no of parameters. For simplicity pass force & yes_i_really_mean_it parameters to method.

vamahaja · 2024-05-23T12:08:05Z

cli/ceph/orch/host.py

@@ -1,5 +1,8 @@
 from cli import Cli
 from cli.utilities.utils import build_cmd_from_args
+from utility.log import Log
+
+log = Log(__name__)


Unused variable

vamahaja · 2024-05-23T12:11:18Z

cli/ops/host.py

+    log.info(f"Status of the host is {host_status}")
+    if status:
+        return True if status.lower() == host_status else False
+    elif "offline" in host_status:


offline status will be specific condition. It can be handled by passing it through status.

vamahaja · 2024-05-23T12:12:54Z

cli/ops/host.py

+    """
+    log.debug(f"Passed host : {hostname} to be added into maintenance mode")
+    iteration = 0
+    while iteration <= retry:


Use - https://github.com/red-hat-storage/cephci/blob/master/cli/utilities/waiter.py

vamahaja · 2024-05-23T12:13:36Z

cli/ops/host.py

+        log.info(f"Host: {hostname}, not in maintenance mode. Pass")
+        return True
+
+    while iteration <= retry:


Use - https://github.com/red-hat-storage/cephci/blob/master/cli/utilities/waiter.py

vamahaja · 2024-05-23T12:16:59Z

tests/cephadm/test_add_host_to_maintenance_using_flags.py

+    installer = ceph_cluster.get_nodes(role="installer")[0]
+
+    # Create a pool
+    out = orch_obj.create_pool(**pool_config)


Add method here to create osd pool - https://github.com/red-hat-storage/cephci/blob/master/cli/ceph/osd/pool.py

sayaleeraut force-pushed the test_bz_2111539 branch from d150833 to 1fbfb60 Compare May 9, 2024 06:49

sayaleeraut self-assigned this May 9, 2024

sayaleeraut requested review from adityaramteke, vamahaja, MohitBis, pranavprakash20 and tintumathew10 May 9, 2024 06:50

pranavprakash20 requested changes May 9, 2024

View reviewed changes

openshift-ci bot assigned pranavprakash20 May 9, 2024

sayaleeraut force-pushed the test_bz_2111539 branch from 1fbfb60 to 2ef80b8 Compare May 9, 2024 07:55

vamahaja requested changes May 9, 2024

View reviewed changes

openshift-ci bot assigned vamahaja May 9, 2024

sayaleeraut force-pushed the test_bz_2111539 branch 5 times, most recently from 51c33f0 to 7d60971 Compare May 22, 2024 10:08

sayaleeraut force-pushed the test_bz_2111539 branch 2 times, most recently from 36a6e70 to c3395fc Compare May 22, 2024 16:47

[Test] Add host to maintenance using flags

8dbe1ee

Signed-off-by: “sayalee” <saraut@redhat.com>

sayaleeraut force-pushed the test_bz_2111539 branch from c3395fc to 8dbe1ee Compare May 22, 2024 17:00

vamahaja reviewed May 23, 2024

View reviewed changes

vamahaja requested changes May 23, 2024

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Test] Add host to maintenance using flags #3678

[Test] Add host to maintenance using flags #3678

sayaleeraut commented May 9, 2024

openshift-ci bot commented May 9, 2024

sayaleeraut commented May 9, 2024

vamahaja May 9, 2024

vamahaja May 9, 2024

vamahaja May 9, 2024

sayaleeraut May 15, 2024

vamahaja May 9, 2024

sayaleeraut May 14, 2024

sayaleeraut May 16, 2024

vamahaja May 9, 2024

sayaleeraut May 16, 2024

sayaleeraut commented May 22, 2024

vamahaja May 23, 2024

vamahaja May 23, 2024

vamahaja May 23, 2024

vamahaja May 23, 2024

vamahaja May 23, 2024

vamahaja May 23, 2024

vamahaja May 23, 2024

[Test] Add host to maintenance using flags #3678

Are you sure you want to change the base?

[Test] Add host to maintenance using flags #3678

Conversation

sayaleeraut commented May 9, 2024

Description

openshift-ci bot commented May 9, 2024

sayaleeraut commented May 9, 2024

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

sayaleeraut commented May 22, 2024

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment