Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Test] Verify monitoring stack image version using ceph orchestrator #3687

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

[Test] Verify monitoring stack image version using ceph orchestrator #3687

wants to merge 1 commit into from

Conversation

sayaleeraut
Copy link
Contributor

Description

Please include Automation development guidelines. Source of Test case - New Feature/Regression Test/Close loop of customer BZs

click to expand checklist
  • Create a test case in Polarion reviewed and approved.
  • Create a design/automation approach doc. Optional for tests with similar tests already automated.
  • Review the automation design
  • Implement the test script and perform test runs
  • Submit PR for code review and approve
  • Update Polarion Test with Automation script details and update automation fields
  • If automation is part of Close loop, update BZ flag qe-test_coverage “+” and link Polarion test

@sayaleeraut sayaleeraut self-assigned this May 13, 2024
@sayaleeraut
Copy link
Contributor Author

Tox results -

py3: commands[1]> flake8
py3: commands[2]> isort -c .
Skipped 3 files
py3: commands[3]> black --check --diff .
All done! ✨ 🍰 ✨
1046 files would be left unchanged.
py3: commands[4]> yamllint -d relaxed --no-warnings .
.pkg: _exit> python /Library/Frameworks/Python.framework/Versions/3.11/lib/python3.11/site-packages/pyproject_api/_backend.py True setuptools.build_meta legacy
py3: OK (23.69=setup[3.80]+cmd[0.49,1.41,1.28,2.69,14.03] seconds)
congratulations :) (23.72 seconds)

@MohitBis
Copy link
Contributor

Hi @sayaleeraut

Can you please add passing logs?

vamahaja
vamahaja requested changes May 17, 2024
View reviewed changes
cli/utilities/containers.py Outdated Show resolved Hide resolved
tests/cephadm/test_ceph_orch_for_monitoring_image_version.py Outdated Show resolved Hide resolved
suites/reef/cephadm/tier1-container-cli-args.yaml Outdated Show resolved Hide resolved
pranavprakash20
pranavprakash20 previously approved these changes May 17, 2024
View reviewed changes
Copy link
Contributor

@pranavprakash20 pranavprakash20 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@openshift-ci openshift-ci bot added the lgtm Add this label when the PR is good to be merged label May 17, 2024
@openshift-ci openshift-ci bot removed the lgtm Add this label when the PR is good to be merged label May 27, 2024
pranavprakash20
pranavprakash20 previously approved these changes Jun 3, 2024
View reviewed changes
Copy link
Contributor

@pranavprakash20 pranavprakash20 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@openshift-ci openshift-ci bot added the lgtm Add this label when the PR is good to be merged label Jun 3, 2024
MohitBis
MohitBis previously approved these changes Jun 3, 2024
View reviewed changes
Copy link
Contributor

@MohitBis MohitBis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

vamahaja
vamahaja requested changes Jun 3, 2024
View reviewed changes
cli/utilities/containers.py Outdated

if image:
cmd += f" {image}"

if cmds:
cmd += f" {cmds}"

if self.execute(sudo=True, long_running=True, cmd=cmd):
out = self.execute(sudo=True, cmd=cmd)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Revert this change, this should be long running command. It will affect existing test cases.

@openshift-ci openshift-ci bot removed the lgtm Add this label when the PR is good to be merged label Jun 3, 2024
@sayaleeraut
[Test] Verify monitoring stack image version using ceph orchestrator
6197edf 
Signed-off-by: “sayalee” <saraut@redhat.com>
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Jun 4, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: sayaleeraut

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

2 similar comments
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Jun 4, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: sayaleeraut

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Jun 4, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: sayaleeraut

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vamahaja vamahaja vamahaja requested changes

@MohitBis MohitBis MohitBis left review comments

@pranavprakash20 pranavprakash20 pranavprakash20 left review comments

@adityaramteke adityaramteke Awaiting requested review from adityaramteke

@vinpapnoi vinpapnoi Awaiting requested review from vinpapnoi

@msainiRedhat msainiRedhat Awaiting requested review from msainiRedhat

@tintumathew10 tintumathew10 Awaiting requested review from tintumathew10

Requested changes must be addressed to merge this pull request.

Assignees

@sayaleeraut sayaleeraut

@vamahaja vamahaja

@MohitBis MohitBis

@pranavprakash20 pranavprakash20

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@sayaleeraut @MohitBis @vamahaja @pranavprakash20