Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Azure KMS support in cluster deployment #9731

Merged
merged 2 commits into from
May 28, 2024

Conversation

paraggit
Copy link
Contributor

Added support for Deployment with Azure KMS.

@paraggit paraggit requested a review from a team as a code owner April 25, 2024 14:54
@pull-request-size pull-request-size bot added the size/L PR that changes 100-499 lines label Apr 25, 2024
@paraggit paraggit changed the title Added support for Deployment with Azure KMS [WIP] Added support for Deployment with Azure KMS Apr 25, 2024
@paraggit paraggit changed the title [WIP] Added support for Deployment with Azure KMS [WIP] Added Azure KMS support in cluster deployment Apr 25, 2024
@paraggit paraggit changed the title [WIP] Added Azure KMS support in cluster deployment Added Azure KMS support in cluster deployment May 4, 2024
@paraggit paraggit requested review from shyRozen and ebenahar May 4, 2024 22:07
Signed-off-by: Parag Kamble <pakamble@redhat.com>
ocs_ci/utility/kms.py Outdated Show resolved Hide resolved
ocs_ci/utility/kms.py Outdated Show resolved Hide resolved
ocs_ci/utility/kms.py Outdated Show resolved Hide resolved
…ctions.

Signed-off-by: Parag Kamble <pakamble@redhat.com>
Copy link

@ocs-ci ocs-ci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR validation

Cluster Name:
Cluster Configuration:
PR Test Suite: tier1
PR Test Path: tests/functional/deployment
Additional Test Params:
OCP VERSION: 4.16
OCS VERSION: 4.16
tested against branch: master

Job FAILED (installation failed, tests not executed).

Copy link

@ocs-ci ocs-ci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR validation

Cluster Name:
Cluster Configuration:
PR Test Suite: deployment
PR Test Path: tests/functional/deployment
Additional Test Params:
OCP VERSION: 4.16
OCS VERSION: 4.16
tested against branch: master

Job FAILED (installation failed, tests not executed).

Copy link

@ocs-ci ocs-ci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR validation

Cluster Name:
Cluster Configuration:
PR Test Suite: deployment
PR Test Path: tests/functional/deployment
Additional Test Params:
OCP VERSION: 4.16
OCS VERSION: 4.16
tested against branch: master

Job PASSED.

@paraggit paraggit added the Verified Mark when PR was verified and log provided label May 6, 2024
@paraggit paraggit requested a review from ebenahar May 6, 2024 19:28
Copy link

openshift-ci bot commented May 28, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: ebenahar, paraggit, sidhant-agrawal

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ebenahar ebenahar merged commit 7dbbe29 into red-hat-storage:master May 28, 2024
6 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm size/L PR that changes 100-499 lines Verified Mark when PR was verified and log provided
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants