WIP: Add option to add additional markexpression #9742
Conversation
|
Verification job: |
|
@petr-balogh can you briefly explain why do we need this approach? |
|
New changes are detected. LGTM label has been removed. |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: petr-balogh The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
1 similar comment
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: petr-balogh The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Signed-off-by: Petr Balogh <pbalogh@redhat.com>
Signed-off-by: Petr Balogh <pbalogh@redhat.com>
petr-balogh
force-pushed
the
add-option-to-add-additional-markexpression
branch
from
6656cf5
to
83de713
Compare
I understood from @shivamdurgbuns that there is such request to run in our production jobs on this arbiter specific setup also the tests decorated with stretchcluster_required. IIUC the requirements that currently we run the production job in nightly pipeline with acceptance marker only - so a lot of test are skipped and not triggered and required by this platform. This approach will allow us to directly specify in specific production configuration job the extra marker to be also executed as part of every our production execution as part of whatever suite which we will have better coverage for other tests for this specific deployment type. Advantage is that we deploy only one job - and be able to run specific platform/deployment related tests as part of that execution as well without need to change the jenkins jobs logic and increase coverage for specific deployment type. But if I understand the requirements wrong please let me know. |
| @@ -334,6 +335,10 @@ def pytest_collection_modifyitems(session, config, items): | |||
| item.user_properties.append(("squad", squad.capitalize())) | |||
|
|
|||
| if not (teardown or deploy or (deploy and skip_ocs_deployment)): | |||
| if ocsci_config.RUN.get("extra_markexpr"): | |||
There was a problem hiding this comment.
We might still have a problem with upgrade scenario when we don't want to have this tests selected.
I am still not sure we want to have this kind of logic if it will be beneficial for us or not. Still trying to go with some pros and cons.
petr-balogh
changed the title
No description provided.