Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New test cast - Ephemeral storage #9747

Merged
merged 7 commits into from
Jun 3, 2024
Merged

New test cast - Ephemeral storage #9747

merged 7 commits into from
Jun 3, 2024

Conversation

AviadP
Copy link
Contributor

@AviadP AviadP commented May 1, 2024

Create test case and infrastructure for ephemeral storage

@AviadP
file created
9e4d3b3 
Signed-off-by: Aviadp <apolak@redhat.com>
@AviadP
Test Created
302455c 
Signed-off-by: Aviadp <apolak@redhat.com>
@AviadP AviadP requested review from a team as code owners May 1, 2024 11:44
@pull-request-size pull-request-size bot added the size/L PR that changes 100-499 lines label May 1, 2024
OdedViner
OdedViner previously approved these changes May 1, 2024
View reviewed changes
@openshift-ci openshift-ci bot added the lgtm label May 1, 2024
@AviadP AviadP changed the title new test cast - Ephemeralstorage New test cast - Ephemeralstorage May 1, 2024
@AviadP AviadP changed the title New test cast - Ephemeralstorage New test cast - Ephemeral storage May 1, 2024
@AviadP AviadP added the Test Case A test case PR label May 1, 2024
@AviadP
added markers
fe56284 
Signed-off-by: Aviadp <apolak@redhat.com>
@openshift-ci openshift-ci bot removed the lgtm label May 15, 2024
prsurve
prsurve previously requested changes May 15, 2024
View reviewed changes
ocs_ci/ocs/ephernal_storage.py Outdated Show resolved Hide resolved
@AviadP
Added Template files, changed image
ae633b7 
Signed-off-by: Aviadp <apolak@redhat.com>
@AviadP
Removed dict from file
fae1d64 
Signed-off-by: Aviadp <apolak@redhat.com>
@AviadP
ready
922ef04 
Signed-off-by: Aviadp <apolak@redhat.com>
@AviadP AviadP requested review from prsurve and OdedViner May 20, 2024 15:43
ocs-ci
ocs-ci reviewed May 20, 2024
View reviewed changes
Copy link

@ocs-ci ocs-ci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR validation on existing cluster

Cluster Name: apolak-may15
Cluster Configuration:
PR Test Suite: tier1
PR Test Path: tests/functional/pod_and_daemons/test_ephemeral_pod.py
Additional Test Params:
OCP VERSION: 4.15-ga
OCS VERSION: 4.16
tested against branch: master

Job PASSED.

@AviadP AviadP added the Verified Mark when PR was verified and log provided label May 21, 2024
ebenahar
ebenahar reviewed May 27, 2024
View reviewed changes
ocs_ci/ocs/ephernal_storage.py Outdated Show resolved Hide resolved
ocs_ci/ocs/ephernal_storage.py Outdated Show resolved Hide resolved
tests/functional/pod_and_daemons/test_ephemeral_pod.py Outdated Show resolved Hide resolved
tests/functional/pod_and_daemons/test_ephemeral_pod.py Outdated Show resolved Hide resolved
tests/functional/pod_and_daemons/test_ephemeral_pod.py Show resolved Hide resolved
@AviadP
Added docstring, fixed typos
4227b01 
Signed-off-by: Aviadp <apolak@redhat.com>
ocs-ci
ocs-ci reviewed Jun 2, 2024
View reviewed changes
Copy link

@ocs-ci ocs-ci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR validation on existing cluster

Cluster Name: apolak-june2
Cluster Configuration:
PR Test Suite: tier1
PR Test Path: tests/functional/pod_and_daemons/test_ephemeral_pod.py
Additional Test Params:
OCP VERSION: 4.15-ga
OCS VERSION: 4.16
tested against branch: master

Job PASSED.

@openshift-ci openshift-ci bot added the lgtm label Jun 3, 2024
@AviadP AviadP requested a review from ebenahar June 3, 2024 09:32
@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Jun 3, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: AviadP, ebenahar, OdedViner

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ebenahar ebenahar merged commit f87c8e2 into red-hat-storage:master Jun 3, 2024
6 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ocs-ci ocs-ci ocs-ci left review comments

@ebenahar ebenahar ebenahar approved these changes

@OdedViner OdedViner OdedViner approved these changes

@prsurve prsurve Awaiting requested review from prsurve

Assignees

@ebenahar ebenahar

@prsurve prsurve

@OdedViner OdedViner

Labels
lgtm size/L PR that changes 100-499 lines Test Case A test case PR Verified Mark when PR was verified and log provided
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@AviadP @ebenahar @prsurve @ocs-ci @OdedViner