Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run pvc resize and clone acceptance test on all clients #9773

Merged
merged 1 commit into from
May 16, 2024

Conversation

ebondare
Copy link
Contributor

@ebondare ebondare commented May 7, 2024

No description provided.

Signed-off-by: Elena Bondarenko <ebondare@redhat.com>
@ebondare ebondare requested a review from a team as a code owner May 7, 2024 14:31
@pull-request-size pull-request-size bot added the size/L PR that changes 100-499 lines label May 7, 2024
@ebondare ebondare changed the title Run pvc resize and clone acceptance test on all clients [WIP] Run pvc resize and clone acceptance test on all clients May 7, 2024
@ebondare ebondare changed the title [WIP] Run pvc resize and clone acceptance test on all clients Run pvc resize and clone acceptance test on all clients May 13, 2024
@ebondare
Copy link
Contributor Author

@ebondare ebondare added the provider-client HCI Provider client solution label May 13, 2024
@@ -25,90 +26,95 @@ class TestAcceptance(ManageTest):
@provider_client_ms_platform_required
def test_acceptance(self, pvc_factory, pod_factory, teardown_factory):
"""
Acceptance test
Acceptance test on all clients
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have a question that's not specific to the changes in this PR. Is there a particular reason why this test has been added to the cross_functional/system_test directory? Looking at the test steps, I don't think it's a relevant place for it

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This have been added because general acceptance tests usually test multiple product components. It was moved here because of the test name but it is true that this test only tests PVCs so it can be renamed and moved to a directory with pvc tests.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the clarification @fbalak. I'm not sure if you'd like to make this change in this PR. I'm providing my approval just in case you want to merge this one and open a new PR for the directory structure change.

Copy link

openshift-ci bot commented May 16, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: DanielOsypenko, ebondare, fbalak, PrasadDesala

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ebondare ebondare added the Verified Mark when PR was verified and log provided label May 16, 2024
@fbalak fbalak merged commit ab20f2d into red-hat-storage:master May 16, 2024
5 of 6 checks passed
amr1ta pushed a commit to amr1ta/ocs-ci that referenced this pull request May 28, 2024
Signed-off-by: Elena Bondarenko <ebondare@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm provider-client HCI Provider client solution size/L PR that changes 100-499 lines Verified Mark when PR was verified and log provided
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants