-
Notifications
You must be signed in to change notification settings - Fork 164
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Run pvc resize and clone acceptance test on all clients #9773
Conversation
Signed-off-by: Elena Bondarenko <ebondare@redhat.com>
@@ -25,90 +26,95 @@ class TestAcceptance(ManageTest): | |||
@provider_client_ms_platform_required | |||
def test_acceptance(self, pvc_factory, pod_factory, teardown_factory): | |||
""" | |||
Acceptance test | |||
Acceptance test on all clients |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have a question that's not specific to the changes in this PR. Is there a particular reason why this test has been added to the cross_functional/system_test directory? Looking at the test steps, I don't think it's a relevant place for it
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This have been added because general acceptance tests usually test multiple product components. It was moved here because of the test name but it is true that this test only tests PVCs so it can be renamed and moved to a directory with pvc tests.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the clarification @fbalak. I'm not sure if you'd like to make this change in this PR. I'm providing my approval just in case you want to merge this one and open a new PR for the directory structure change.
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: DanielOsypenko, ebondare, fbalak, PrasadDesala The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Signed-off-by: Elena Bondarenko <ebondare@redhat.com>
No description provided.