Multus deployment with nmstate operator #9777
Open
+278
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OdedViner
changed the title
Signed-off-by: oviner <oviner@redhat.com>
Signed-off-by: oviner <oviner@redhat.com>
Signed-off-by: oviner <oviner@redhat.com>
OdedViner
force-pushed
the
multus_upgrade_holder_pods
branch
from
d07af6b
to
92d0fbe
Compare
Signed-off-by: oviner <oviner@redhat.com>
ocs-ci
reviewed
May 30, 2024
petr-balogh
reviewed
Jun 3, 2024
conf/deployment/baremetal/upi_1az_rhcos_multus_nvme_intel_3m_3w.yaml
Outdated
Show resolved
Hide resolved
Signed-off-by: oviner <oviner@redhat.com>
dahorak
approved these changes
Jun 3, 2024
There was a problem hiding this comment.
Overall LGTM, just please describe the new parameters in conf/README.md:
node_network_configuration_policy_namenode_network_configuration_policy_ipnode_network_configuration_policy_prefix_lengthnode_network_configuration_policy_destination_route
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: dahorak, OdedViner The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.