Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix failure in test_delete_rbd_pool_associated_with_sc #9790

Merged

Conversation

sidhant-agrawal
Copy link
Contributor

This PR fixes a failing test in the test_delete_rbd_pool_attached_to_sc.py file. One of the parameterized tests was failing due to an incorrect value in the argvalues list. This fix updates the incorrect value to the expected one.

Test case: tests/functional/storageclass/test_delete_rbd_pool_attached_to_sc.py::TestDeleteRbdPool::test_delete_rbd_pool_associated_with_sc
Previous parameters: [2-aggressive-Immediate-Pending]
New parameters: [2-aggressive-WaitForFirstConsumer-Pending]

Fixes: #9462

…_rbd_pool_associated_with_sc

Signed-off-by: Sidhant Agrawal <sagrawal@redhat.com>
@sidhant-agrawal sidhant-agrawal added Squad/Green backport-required Mark for PRs that need to be backported to older release branches labels May 10, 2024
@sidhant-agrawal sidhant-agrawal requested a review from a team as a code owner May 10, 2024 17:12
@sidhant-agrawal sidhant-agrawal added backport-required Mark for PRs that need to be backported to older release branches and removed backport-required Mark for PRs that need to be backported to older release branches labels May 10, 2024
Copy link

@ocs-ci ocs-ci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR validation on existing cluster

Cluster Name: sagrawal-m10
Cluster Configuration:
PR Test Suite: tier1
PR Test Path: tests/functional/storageclass/test_delete_rbd_pool_attached_to_sc.py::TestDeleteRbdPool::test_delete_rbd_pool_associated_with_sc[2-aggressive-WaitForFirstConsumer-Pending]
Additional Test Params:
OCP VERSION: 4.16
OCS VERSION: 4.16
tested against branch: master

Job PASSED.

@sidhant-agrawal sidhant-agrawal added the Verified Mark when PR was verified and log provided label May 10, 2024
@sidhant-agrawal sidhant-agrawal changed the title Fix failing test in test_delete_rbd_pool_attached_to_sc.py Fix failure in test_delete_rbd_pool_associated_with_sc May 11, 2024
Copy link

openshift-ci bot commented May 23, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: am-agrawa, jilju, paraggit, sidhant-agrawal

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sidhant-agrawal sidhant-agrawal merged commit 58b67dc into red-hat-storage:master May 23, 2024
6 of 7 checks passed
@sidhant-agrawal
Copy link
Contributor Author

/cherrypick release-4.15

@openshift-cherrypick-robot
Copy link
Collaborator

@sidhant-agrawal: new pull request created: #9846

In response to this:

/cherrypick release-4.15

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-required Mark for PRs that need to be backported to older release branches lgtm size/XS Squad/Green Verified Mark when PR was verified and log provided
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Investigate unstable testcases in test_delete_rbd_pool_attached_to_sc.py
6 participants