Add RBAC for creating service monitors from mgr sidecar #1229
Conversation
Stretch clusters have two mgrs, each with a sidecar for updating the services and service monitor if the active mgr changes in Ceph. The mgr pod needs access to update the service monitor. Signed-off-by: Travis Nielsen <tnielsen@redhat.com>
Signed-off-by: Travis Nielsen <tnielsen@redhat.com>
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jarrpa The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
lgtm
|
/cherrypick release-4.8 |
|
@jarrpa: once the present PR merges, I will cherry-pick it on top of release-4.8 in a new PR and assign it to you. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/test ocs-operator-bundle-e2e-aws |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
6 similar comments
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
@jarrpa: new pull request created: #1230 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Stretch clusters have two mgrs, each with a sidecar for updating the services and service monitor if the active mgr changes in Ceph. The mgr pod needs access to update the service monitor.
In order for the monitoring RBAC to be picked up, it needs to be added to the OCS operator in this folder:
https://github.com/openshift/ocs-operator/tree/master/rbac
This corresponds to the RBAC that was added upstream in this PR: rook/rook#8118