Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug 2277926: [release-4.13] Add waitTimeoutForHealthyOSDInMinutes field in the storagecluster CR #2590

Conversation

Nikhil-Ladha
Copy link
Member

This is a manual backport of #2579

Add new waitTimeoutForHealthyOSDInMinutes field under
ManageCephCluster in the storagecluster CR, to allow users
to override defaults in the CephCluster.

Signed-off-by: Nikhil-Ladha <nikhilladha1999@gmail.com>
Copy link
Contributor

openshift-ci bot commented Apr 30, 2024

@Nikhil-Ladha: No Bugzilla bug is referenced in the title of this pull request.
To reference a bug, add 'Bug XXX:' to the title of this pull request and request another bug refresh with /bugzilla refresh.

In response to this:

Add waitTimeoutForHealthyOSDInMinutes field in the storagecluster CR

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@Nikhil-Ladha Nikhil-Ladha changed the title Add waitTimeoutForHealthyOSDInMinutes field in the storagecluster CR Bug 2277926: [release-41.3] Add waitTimeoutForHealthyOSDInMinutes field in the storagecluster CR Apr 30, 2024
@openshift-ci openshift-ci bot added bugzilla/severity-medium Referenced Bugzilla bug's severity is medium for the branch this PR is targeting. bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. labels Apr 30, 2024
Copy link
Contributor

openshift-ci bot commented Apr 30, 2024

@Nikhil-Ladha: This pull request references Bugzilla bug 2277926, which is invalid:

  • expected the bug to target the "ODF 4.13.9" release, but it targets "---" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Bug 2277926: [release-41.3] Add waitTimeoutForHealthyOSDInMinutes field in the storagecluster CR

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@Nikhil-Ladha
Copy link
Member Author

The failure for go1.20 is expected because of the changes in the time package of go1.20.

@Nikhil-Ladha Nikhil-Ladha changed the title Bug 2277926: [release-41.3] Add waitTimeoutForHealthyOSDInMinutes field in the storagecluster CR Bug 2277926: [release-4.13] Add waitTimeoutForHealthyOSDInMinutes field in the storagecluster CR May 2, 2024
@Nikhil-Ladha
Copy link
Member Author

/bugzilla refresh

@openshift-ci openshift-ci bot added the bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. label May 23, 2024
Copy link
Contributor

openshift-ci bot commented May 23, 2024

@Nikhil-Ladha: This pull request references Bugzilla bug 2277926, which is valid.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (ODF 4.13.9) matches configured target release for branch (ODF 4.13.9)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

No GitHub users were found matching the public email listed for the QA contact in Bugzilla (ebenahar@redhat.com), skipping review request.

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-ci openshift-ci bot removed the bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. label May 23, 2024
@openshift-ci openshift-ci bot added lgtm Indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels May 23, 2024
Upgrade operator-sdk version to 1.25.4 to allow successfull
csv builds in CI for go1.20, due to new changes introduced
in golang time package from go1.20 onwards

Signed-off-by: Nikhil-Ladha <nikhilladha1999@gmail.com>
add generated csv, crd changes

Signed-off-by: Nikhil-Ladha <nikhilladha1999@gmail.com>
@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label May 23, 2024
@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label May 23, 2024
Copy link
Contributor

openshift-ci bot commented May 23, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: iamniting, Nikhil-Ladha

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit 6780aec into red-hat-storage:release-4.13 May 23, 2024
14 checks passed
Copy link
Contributor

openshift-ci bot commented May 23, 2024

@Nikhil-Ladha: All pull requests linked via external trackers have merged:

Bugzilla bug 2277926 has been moved to the MODIFIED state.

In response to this:

Bug 2277926: [release-4.13] Add waitTimeoutForHealthyOSDInMinutes field in the storagecluster CR

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/severity-medium Referenced Bugzilla bug's severity is medium for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants