Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug 2278642: [release-4.14] remove namespace controller #2594

Conversation

Nikhil-Ladha
Copy link
Member

This is a manual backport of #2577

Removed the namespace controller that was added to annotate
namespaces with the reclaimspace annotation. The user will
have to manually annotate the namespaces in which they want
the reclaimspace feature.

Signed-off-by: Nikhil-Ladha <nikhilladha1999@gmail.com>
add generated changes for namespace controller removal

Signed-off-by: Nikhil-Ladha <nikhilladha1999@gmail.com>
@openshift-ci openshift-ci bot added bugzilla/severity-high Referenced Bugzilla bug's severity is high for the branch this PR is targeting. bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. labels May 2, 2024
Copy link
Contributor

openshift-ci bot commented May 2, 2024

@Nikhil-Ladha: This pull request references Bugzilla bug 2278578, which is invalid:

  • expected the bug to target the "ODF 4.14.7" release, but it targets "---" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Bug 2278578: [release-4.14] remove namespace controller

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@Nikhil-Ladha Nikhil-Ladha changed the title Bug 2278578: [release-4.14] remove namespace controller Bug 2278642: [release-4.14] remove namespace controller May 2, 2024
Copy link
Contributor

openshift-ci bot commented May 2, 2024

@Nikhil-Ladha: This pull request references Bugzilla bug 2278642, which is invalid:

  • expected the bug to target the "ODF 4.14.7" release, but it targets "---" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Bug 2278642: [release-4.14] remove namespace controller

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@agarwal-mudit
Copy link
Member

/bugzilla refresh

@openshift-ci openshift-ci bot added bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. and removed bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. labels May 27, 2024
Copy link
Contributor

openshift-ci bot commented May 27, 2024

@agarwal-mudit: This pull request references Bugzilla bug 2278642, which is valid. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (ODF 4.14.8) matches configured target release for branch (ODF 4.14.8)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

No GitHub users were found matching the public email listed for the QA contact in Bugzilla (ebenahar@redhat.com), skipping review request.

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@agarwal-mudit
Copy link
Member

/lgtm
/approve

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label May 27, 2024
Copy link
Contributor

openshift-ci bot commented May 27, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: agarwal-mudit, Nikhil-Ladha

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 27, 2024
@openshift-merge-bot openshift-merge-bot bot merged commit 9375f89 into red-hat-storage:release-4.14 May 27, 2024
11 checks passed
Copy link
Contributor

openshift-ci bot commented May 27, 2024

@Nikhil-Ladha: All pull requests linked via external trackers have merged:

Bugzilla bug 2278642 has been moved to the MODIFIED state.

In response to this:

Bug 2278642: [release-4.14] remove namespace controller

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/severity-high Referenced Bugzilla bug's severity is high for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants