Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug 2213757:[release-4.16] external: seaprate rgw endpoint validation from cephfs and rbd sc #2607

Merged
merged 1 commit into from
May 14, 2024
Merged

Bug 2213757:[release-4.16] external: seaprate rgw endpoint validation from cephfs and rbd sc #2607

merged 1 commit into from
May 14, 2024

Conversation

openshift-cherrypick-robot
Copy link

This is an automated cherry-pick of #2585

/assign agarwal-mudit

@parth-gr
external: seaprate rgw endpoint validation from cephfs and rbd sc
56ab5f9 
currently if the rgw endpoint is not reachable
all the storageclass creation fails
Fix will make the rgw endpoint validation separate and will
create rbd and cephfs storageclasses if rgw endpoints validation
fails

Signed-off-by: parth-gr <partharora1010@gmail.com>
@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request May 14, 2024
Merged
@parth-gr
Copy link
Member

@agarwal-mudit @iamniting @umangachapagain can we get this merged....

@iamniting iamniting changed the title [release-4.16] external: seaprate rgw endpoint validation from cephfs and rbd sc Bug 2213757:[release-4.16] external: seaprate rgw endpoint validation from cephfs and rbd sc May 14, 2024
@openshift-ci openshift-ci bot added bugzilla/severity-high Referenced Bugzilla bug's severity is high for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. labels May 14, 2024
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented May 14, 2024

@openshift-cherrypick-robot: This pull request references Bugzilla bug 2213757, which is valid.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (ODF 4.16.0) matches configured target release for branch (ODF 4.16.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

Requesting review from QA contact:
/cc @vavuthu

In response to this:

Bug 2213757:[release-4.16] external: seaprate rgw endpoint validation from cephfs and rbd sc

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented May 14, 2024

@openshift-ci[bot]: GitHub didn't allow me to request PR reviews from the following users: vavuthu.

Note that only red-hat-storage members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to this:

@openshift-cherrypick-robot: This pull request references Bugzilla bug 2213757, which is valid.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (ODF 4.16.0) matches configured target release for branch (ODF 4.16.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

Requesting review from QA contact:
/cc @vavuthu

In response to this:

Bug 2213757:[release-4.16] external: seaprate rgw endpoint validation from cephfs and rbd sc

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label May 14, 2024
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented May 14, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: iamniting, openshift-cherrypick-robot

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 14, 2024
@iamniting
Copy link
Member

/test ocs-operator-bundle-e2e-aws

@openshift-merge-bot openshift-merge-bot bot merged commit 43fa925 into red-hat-storage:release-4.16 May 14, 2024
11 checks passed
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented May 14, 2024

@openshift-cherrypick-robot: All pull requests linked via external trackers have merged:

Bugzilla bug 2213757 has been moved to the MODIFIED state.

In response to this:

Bug 2213757:[release-4.16] external: seaprate rgw endpoint validation from cephfs and rbd sc

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iamniting iamniting iamniting approved these changes

Assignees

@iamniting iamniting

@agarwal-mudit agarwal-mudit

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/severity-high Referenced Bugzilla bug's severity is high for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@openshift-cherrypick-robot @parth-gr @iamniting @agarwal-mudit