-
Notifications
You must be signed in to change notification settings - Fork 177
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bug 2262943: [release-4.16] Make all alerts/rules compatible with multicluster mode #2608
Conversation
Added 'managedBy' label and 'rook-ceph-mgr-external' job to expressions (where it was needed) to avoid any conflicting results. These changes make sure that we don't have any 'PrometheusRuleFailures' in a multicluster mode scenario Signed-off-by: Arun Kumar Mohan <amohan@redhat.com> (cherry picked from commit 31820dc)
@aruniiird: No Bugzilla bug is referenced in the title of this pull request. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
This is a 4.16 backport PR for PR #2596 |
/assign @umangachapagain @umangachapagain , can you please take a look? |
@aruniiird: This pull request references Bugzilla bug 2262943, which is invalid:
Comment In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
/bugzilla refresh |
@aruniiird: This pull request references Bugzilla bug 2262943, which is valid. The bug has been updated to refer to the pull request using the external bug tracker. 3 validation(s) were run on this bug
No GitHub users were found matching the public email listed for the QA contact in Bugzilla (fbalak@redhat.com), skipping review request. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
@umangachapagain , @agarwal-mudit , can we please merge this backport PR? |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: agarwal-mudit, aruniiird The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
591c32c
into
red-hat-storage:release-4.16
@aruniiird: All pull requests linked via external trackers have merged: Bugzilla bug 2262943 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
/bugzilla refresh |
@aruniiird: Bugzilla bug 2262943 is in an unrecognized state (MODIFIED) and will not be moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Added 'managedBy' label and 'rook-ceph-mgr-external' job to expressions (where it was needed) to avoid any
conflicting results. These changes make sure that we don't have any 'PrometheusRuleFailures' in a multicluster mode scenario
Signed-off-by: Arun Kumar Mohan amohan@redhat.com
(cherry picked from commit 31820dc)