Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug 2262943: [release-4.16] Make all alerts/rules compatible with multicluster mode #2608

Conversation

aruniiird
Copy link
Contributor

Added 'managedBy' label and 'rook-ceph-mgr-external' job to expressions (where it was needed) to avoid any
conflicting results. These changes make sure that we don't have any 'PrometheusRuleFailures' in a multicluster mode scenario

Signed-off-by: Arun Kumar Mohan amohan@redhat.com
(cherry picked from commit 31820dc)

Added 'managedBy' label and 'rook-ceph-mgr-external' job
to expressions (where it was needed) to avoid any
conflicting results. These changes make sure that we don't
have any 'PrometheusRuleFailures' in a multicluster mode
scenario

Signed-off-by: Arun Kumar Mohan <amohan@redhat.com>
(cherry picked from commit 31820dc)
Copy link
Contributor

openshift-ci bot commented May 14, 2024

@aruniiird: No Bugzilla bug is referenced in the title of this pull request.
To reference a bug, add 'Bug XXX:' to the title of this pull request and request another bug refresh with /bugzilla refresh.

In response to this:

Make all alerts/rules compatible with multicluster mode

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@aruniiird
Copy link
Contributor Author

This is a 4.16 backport PR for PR #2596

@aruniiird
Copy link
Contributor Author

/assign @umangachapagain

@umangachapagain , can you please take a look?

@aruniiird aruniiird changed the title Make all alerts/rules compatible with multicluster mode Bug 2262943: [release-4.16] Make all alerts/rules compatible with multicluster mode May 14, 2024
@openshift-ci openshift-ci bot added bugzilla/severity-medium Referenced Bugzilla bug's severity is medium for the branch this PR is targeting. bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. labels May 14, 2024
Copy link
Contributor

openshift-ci bot commented May 14, 2024

@aruniiird: This pull request references Bugzilla bug 2262943, which is invalid:

  • expected the bug to be in one of the following states: NEW, ASSIGNED, ON_DEV, POST, POST, but it is MODIFIED instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Bug 2262943: [release-4.16] Make all alerts/rules compatible with multicluster mode

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@aruniiird
Copy link
Contributor Author

/bugzilla refresh

@openshift-ci openshift-ci bot added bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. and removed bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. labels May 14, 2024
Copy link
Contributor

openshift-ci bot commented May 14, 2024

@aruniiird: This pull request references Bugzilla bug 2262943, which is valid. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (ODF 4.16.0) matches configured target release for branch (ODF 4.16.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

No GitHub users were found matching the public email listed for the QA contact in Bugzilla (fbalak@redhat.com), skipping review request.

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@aruniiird
Copy link
Contributor Author

@umangachapagain , @agarwal-mudit , can we please merge this backport PR?
This is a backport from PR #2596

@agarwal-mudit
Copy link
Member

/lgtm
/approve

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label May 16, 2024
Copy link
Contributor

openshift-ci bot commented May 16, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: agarwal-mudit, aruniiird

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 16, 2024
@openshift-merge-bot openshift-merge-bot bot merged commit 591c32c into red-hat-storage:release-4.16 May 16, 2024
11 checks passed
Copy link
Contributor

openshift-ci bot commented May 16, 2024

@aruniiird: All pull requests linked via external trackers have merged:

Bugzilla bug 2262943 has been moved to the MODIFIED state.

In response to this:

Bug 2262943: [release-4.16] Make all alerts/rules compatible with multicluster mode

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@aruniiird
Copy link
Contributor Author

/bugzilla refresh

Copy link
Contributor

openshift-ci bot commented May 16, 2024

@aruniiird: Bugzilla bug 2262943 is in an unrecognized state (MODIFIED) and will not be moved to the MODIFIED state.

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/severity-medium Referenced Bugzilla bug's severity is medium for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants