Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set CSI_DISABLE_HOLDER_PODS to true for all clusters 4.17 and onwards #2609

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Set CSI_DISABLE_HOLDER_PODS to true for all clusters 4.17 and onwards #2609

wants to merge 2 commits into from
+6 −19

Conversation

iamniting
Copy link
Member

Customers have had one release (4.16) for migration, As planned we are updating this setting.

Signed-off-by: Nitin Goyal nigoyal@redhat.com

@iamniting
Set CSI_DISABLE_HOLDER_PODS to true for all clusters 4.17 and onwards
2cbe8cb 
Customers have had one release (4.16) for migration, As planned we are
updating this setting.

Signed-off-by: Nitin Goyal <nigoyal@redhat.com>
@iamniting iamniting requested a review from BlaineEXE May 14, 2024 14:25
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented May 14, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: iamniting

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 14, 2024
@iamniting
Refactor function to consolidate all configmap keys in one place
2ea2654 
Signed-off-by: Nitin Goyal <nigoyal@redhat.com>
@iamniting
Copy link
Member Author

iamniting commented May 14, 2024 •
edited

@BlaineEXE Do we have a story created in the JIRA to complete this task? Are we tracking it somewhere?

@BlaineEXE
Copy link
Contributor

No, and I should verify with PM that we want to take this change for 4.17. Please don't merge this until we are certain.

Currently, all greenfield clusters will have holders disabled, which is the minimum requirement for 4.17+.

@iamniting
Copy link
Member Author

/hold

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 15, 2024
@iamniting
Copy link
Member Author

No, and I should verify with PM that we want to take this change for 4.17. Please don't merge this until we are certain.

Currently, all greenfield clusters will have holders disabled, which is the minimum requirement for 4.17+.

Pls do let me know once you have the info.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BlaineEXE BlaineEXE Awaiting requested review from BlaineEXE

At least 2 approving reviews are required to merge this pull request.

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@iamniting @BlaineEXE