Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

exporter: add metric and alert if a system has OSD based on LVM #2612

Merged

Conversation

weirdwiz
Copy link
Contributor

@weirdwiz weirdwiz commented May 15, 2024

@weirdwiz weirdwiz force-pushed the lvm-osd-deprecated-alert branch 2 times, most recently from 9b5b64a to a154648 Compare May 15, 2024 11:19
metrics/deploy/prometheus-ocs-rules.yaml Outdated Show resolved Hide resolved
metrics/deploy/prometheus-ocs-rules.yaml Outdated Show resolved Hide resolved
@weirdwiz weirdwiz force-pushed the lvm-osd-deprecated-alert branch 3 times, most recently from 527c44c to bddb03e Compare May 22, 2024 07:19
@weirdwiz
Copy link
Contributor Author

ptal @umangachapagain @aruniiird

@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label May 22, 2024
metrics/deploy/prometheus-ocs-rules.yaml Outdated Show resolved Hide resolved
metrics/deploy/prometheus-ocs-rules.yaml Outdated Show resolved Hide resolved
@weirdwiz weirdwiz force-pushed the lvm-osd-deprecated-alert branch 2 times, most recently from 6591d17 to 3254fcb Compare May 23, 2024 08:02
@openshift-merge-robot openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label May 23, 2024
this commit updates the rook api to latest release-1.13 branch, to add
support for deprecatedOSDs field

Signed-off-by: Divyansh Kamboj <dkamboj@redhat.com>
this commit adds the new metric that counts the number of legacy OSD in
a cluster, ocs_lvm_osd_count(cluster_name, namespace)

Signed-off-by: Divyansh Kamboj <dkamboj@redhat.com>
metrics/deploy/prometheus-ocs-rules.yaml Outdated Show resolved Hide resolved
metrics/internal/collectors/ceph-cluster.go Outdated Show resolved Hide resolved
Signed-off-by: Divyansh Kamboj <dkamboj@redhat.com>
@agarwal-mudit
Copy link
Member

/cherry-pick release-4.16

@openshift-cherrypick-robot

@agarwal-mudit: once the present PR merges, I will cherry-pick it on top of release-4.16 in a new PR and assign it to you.

In response to this:

/cherry-pick release-4.16

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label May 28, 2024
Copy link
Contributor

openshift-ci bot commented May 28, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: umangachapagain, weirdwiz

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 28, 2024
@openshift-merge-bot openshift-merge-bot bot merged commit da2f40b into red-hat-storage:main May 28, 2024
11 checks passed
@openshift-cherrypick-robot

@agarwal-mudit: #2612 failed to apply on top of branch "release-4.16":

Applying: exporter: update rook api to include deprecatedOSDs
Using index info to reconstruct a base tree...
M	metrics/go.mod
M	metrics/go.sum
M	metrics/vendor/github.com/rook/rook/pkg/apis/ceph.rook.io/v1/annotations.go
M	metrics/vendor/github.com/rook/rook/pkg/apis/ceph.rook.io/v1/keys.go
M	metrics/vendor/github.com/rook/rook/pkg/apis/ceph.rook.io/v1/labels.go
M	metrics/vendor/github.com/rook/rook/pkg/apis/ceph.rook.io/v1/resources.go
M	metrics/vendor/github.com/rook/rook/pkg/apis/ceph.rook.io/v1/types.go
M	metrics/vendor/modules.txt
Falling back to patching base and 3-way merge...
Auto-merging metrics/vendor/modules.txt
CONFLICT (content): Merge conflict in metrics/vendor/modules.txt
Auto-merging metrics/vendor/github.com/rook/rook/pkg/apis/ceph.rook.io/v1/types.go
Auto-merging metrics/go.sum
CONFLICT (content): Merge conflict in metrics/go.sum
Auto-merging metrics/go.mod
CONFLICT (content): Merge conflict in metrics/go.mod
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0001 exporter: update rook api to include deprecatedOSDs
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".

In response to this:

/cherry-pick release-4.16

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants