segregate odf collection from default #149
Conversation
|
We'll need to backport this as well to specific branches. |
|
/cherry-pick release-4.15 |
|
@black-dragon74: once the present PR merges, I will cherry-pick it on top of release-4.15 in a new PR and assign it to you. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/cherry-pick release-4.16 |
|
@black-dragon74: once the present PR merges, I will cherry-pick it on top of release-4.16 in a new PR and assign it to you. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
for 4.15 we acks are given only for urgent and important PR's. We can have it only in 4.16. |
|
@black-dragon74 please re-review the PR, I have tested it, It works fine now |
You do not need to pass base_collection_path to any of the subscripts. Just |
Currently the default and odf mode collects all the resouces. This commit segregates the odf mode from default mode. Signed-off-by: yati1998 <ypadia@redhat.com>
|
@black-dragon74 please do reviw the PR again |
collection-scripts/gather
Outdated
| gather_main & | ||
| gather_ceph_pod_logs & | ||
| pids+=($!) | ||
| gather_ceph_logs ${BASE_COLLECTION_PATH} & |
There was a problem hiding this comment.
| gather_ceph_logs ${BASE_COLLECTION_PATH} & | |
| gather_ceph_logs & |
And vice-versa for subsequent calls. BASE_COLLECTION_PATH is exported globally and is accessible to all the sub scripts.
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: black-dragon74, yati1998 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-merge-bot
bot
merged commit 5422239
into
red-hat-storage:main
|
@black-dragon74: new pull request created: #159 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
@black-dragon74: new pull request created: #160 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Currently the default and odf mode collects all the resouces. This commit segregates the odf mode
from default mode.