Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug 2276401: Selectively define ApplicationSet spec to drop argocd mod deps #246

Open
wants to merge 2 commits into
base: release-4.13
Choose a base branch
from

Conversation

ShyamsundarR
Copy link

*** THIS IS A HACK!!!

To remove the k8s and subsequent go mod dependency problems, selectively define a local ArgoCD ApplicationSet type within the code, and use the same for listing and looking at required fields in an ApplicationSet.

If ArgoCD API versions change, we may have to relook at the fields and which are non-optional, to redo parts of this for the next API version.

Signed-off-by: Shyamsundar Ranganathan srangana@redhat.com
(cherry picked from commit d0abb28) (cherry picked from commit 8341c8b)

*** THIS IS A HACK!!!

To remove the k8s and subsequent go mod dependency problems,
selectively define a local ArgoCD ApplicationSet type within
the code, and use the same for listing and looking at required
fields in an ApplicationSet.

If ArgoCD API versions change, we may have to relook at the
fields and which are non-optional, to redo parts of this for
the next API version.

Signed-off-by: Shyamsundar Ranganathan <srangana@redhat.com>
(cherry picked from commit d0abb28)
(cherry picked from commit 8341c8b)
Copy link

openshift-ci bot commented Apr 26, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: ShyamsundarR

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link

openshift-ci bot commented Apr 26, 2024

@ShyamsundarR: This pull request references Bugzilla bug 2276401, which is invalid:

  • expected the bug to target the "ODF 4.13.9" release, but it targets "ODF 4.16.0" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Bug 2276401: Selectively define ApplicationSet spec to drop argocd mod deps

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Signed-off-by: Shyamsundar Ranganathan <srangana@redhat.com>
(cherry picked from commit 00a6d86)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
1 participant