Bug 2268174: external: change cluster_name to k8s_cluster_name #530

parth-gr · 2023-10-18T13:51:01Z

it was confusing if we are calling a ceph cluster name or k8s cluster name, so re-named

(cherry picked from commit 98c4567)

Description of your changes:

Which issue is resolved by this Pull Request:
Resolves #

Checklist:

Commit Message Formatting: Commit titles and messages follow guidelines in the developer guide).
Skip Tests for Docs: If this is only a documentation change, add the label skip-ci on the PR.
Reviewed the developer guide on Submitting a Pull Request
Pending release notes updated with breaking and/or notable changes for the next minor release.
Documentation has been updated, if necessary.
Unit tests have been added, if necessary.
Integration tests have been added, if necessary.

openshift-ci · 2023-10-18T13:51:08Z

@parth-gr: This pull request references Bugzilla bug 2244609, which is invalid:

expected the bug to target the "ODF 4.14.0" release, but it targets "---" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

BlaineEXE · 2023-10-18T16:15:13Z

/approve
/lgtm

BlaineEXE · 2023-10-18T16:16:48Z

.github/workflows/canary-integration-test.yml

-          # print upgraded client auth
+          #  --k8s-cluster-name and --run-as-user flag while upgrading
+          kubectl -n rook-ceph exec $toolbox -- python3 /etc/ceph/create-external-cluster-resources.py --upgrade --rbd-data-pool-name replicapool --k8s-cluster-name rookstorage  --run-as-user client.csi-rbd-node-rookstorage-replicapool
+          # print ugraded client auth


Is this spelling error something we should fix here, or go back to the Rook upstream with?

thanks for pointing
It was updated with some PR
https://github.com/rook/rook/pull/12811/files, By mistake in merge conflict It took the older changes

openshift-bot · 2023-10-19T01:00:52Z

/bugzilla refresh

Recalculating validity in case the underlying Bugzilla bug has changed.

openshift-ci · 2023-10-19T01:00:56Z

@openshift-bot: This pull request references Bugzilla bug 2244609, which is invalid:

expected the bug to target the "ODF 4.14.0" release, but it targets "---" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-bot · 2023-10-20T01:00:30Z

/bugzilla refresh

Recalculating validity in case the underlying Bugzilla bug has changed.

openshift-ci · 2023-10-20T01:00:34Z

@openshift-bot: This pull request references Bugzilla bug 2244609, which is invalid:

expected the bug to target the "ODF 4.14.0" release, but it targets "---" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-bot · 2023-10-21T01:00:13Z

/bugzilla refresh

Recalculating validity in case the underlying Bugzilla bug has changed.

openshift-ci · 2023-10-21T01:00:18Z

@openshift-bot: This pull request references Bugzilla bug 2244609, which is invalid:

expected the bug to target the "ODF 4.14.0" release, but it targets "---" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-bot · 2023-10-22T01:00:12Z

/bugzilla refresh

Recalculating validity in case the underlying Bugzilla bug has changed.

openshift-ci · 2023-10-22T01:00:16Z

@openshift-bot: This pull request references Bugzilla bug 2244609, which is invalid:

expected the bug to target the "ODF 4.14.0" release, but it targets "---" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-bot · 2023-10-23T01:00:16Z

/bugzilla refresh

Recalculating validity in case the underlying Bugzilla bug has changed.

openshift-ci · 2023-10-23T01:00:20Z

@openshift-bot: This pull request references Bugzilla bug 2244609, which is invalid:

expected the bug to target the "ODF 4.14.0" release, but it targets "---" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-bot · 2023-10-24T01:01:08Z

/bugzilla refresh

Recalculating validity in case the underlying Bugzilla bug has changed.

openshift-ci · 2023-10-24T01:01:12Z

@openshift-bot: This pull request references Bugzilla bug 2244609, which is invalid:

expected the bug to target the "ODF 4.14.0" release, but it targets "---" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-bot · 2023-10-25T01:01:09Z

/bugzilla refresh

Recalculating validity in case the underlying Bugzilla bug has changed.

openshift-ci · 2023-10-25T01:01:13Z

@openshift-bot: This pull request references Bugzilla bug 2244609, which is invalid:

expected the bug to target the "ODF 4.14.0" release, but it targets "---" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

it was confusing if we are calling a ceph cluster name or k8s cluster name, so re-named Signed-off-by: parth-gr <paarora@redhat.com> (cherry picked from commit 98c4567) Signed-off-by: parth-gr <paarora@redhat.com>

openshift-ci · 2023-10-26T19:41:09Z

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: BlaineEXE, parth-gr

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

BlaineEXE · 2023-10-26T19:42:05Z

@travisn should we do anything about the docs-check or macos-build here? It seems to me like we might need to live with those failures this late in the process, but not sure.

travisn · 2023-10-26T20:10:42Z

My opinion is let's cherry-pick CI fixes whenever merging other fixes like this. Note that we're waiting for this BZ to be approved for 4.14.z, so it may be a matter of weeks still to merge this.

openshift-ci · 2023-12-04T01:00:16Z

@openshift-bot: This pull request references Bugzilla bug 2244609, which is invalid:

expected the bug to target the "ODF 4.14.1" release, but it targets "---" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-bot · 2023-12-05T01:00:39Z

/bugzilla refresh

Recalculating validity in case the underlying Bugzilla bug has changed.

openshift-ci · 2023-12-05T01:01:14Z

@openshift-bot: This pull request references Bugzilla bug 2244609, which is invalid:

expected the bug to target the "ODF 4.14.1" release, but it targets "---" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-bot · 2023-12-06T01:01:09Z

/bugzilla refresh

Recalculating validity in case the underlying Bugzilla bug has changed.

openshift-ci · 2023-12-06T01:01:49Z

@openshift-bot: This pull request references Bugzilla bug 2244609, which is invalid:

expected the bug to target the "ODF 4.14.1" release, but it targets "---" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-bot · 2023-12-07T01:00:39Z

/bugzilla refresh

Recalculating validity in case the underlying Bugzilla bug has changed.

openshift-ci · 2023-12-07T01:00:47Z

@openshift-bot: This pull request references Bugzilla bug 2244609, which is invalid:

expected the bug to target the "ODF 4.14.1" release, but it targets "---" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-bot · 2023-12-08T01:00:30Z

/bugzilla refresh

Recalculating validity in case the underlying Bugzilla bug has changed.

openshift-ci · 2023-12-08T01:00:34Z

@openshift-bot: This pull request references Bugzilla bug 2244609, which is invalid:

expected the bug to target the "ODF 4.14.1" release, but it targets "---" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-bot · 2023-12-09T01:00:32Z

/bugzilla refresh

Recalculating validity in case the underlying Bugzilla bug has changed.

openshift-ci · 2023-12-09T01:00:42Z

@openshift-bot: This pull request references Bugzilla bug 2244609, which is invalid:

expected the bug to target the "ODF 4.14.1" release, but it targets "---" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-bot · 2023-12-10T01:00:16Z

/bugzilla refresh

Recalculating validity in case the underlying Bugzilla bug has changed.

openshift-ci · 2023-12-10T01:00:22Z

@openshift-bot: This pull request references Bugzilla bug 2244609, which is invalid:

expected the bug to target the "ODF 4.14.1" release, but it targets "---" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-bot · 2023-12-11T01:00:17Z

/bugzilla refresh

Recalculating validity in case the underlying Bugzilla bug has changed.

openshift-ci · 2023-12-11T01:00:22Z

@openshift-bot: This pull request references Bugzilla bug 2244609, which is invalid:

expected the bug to target the "ODF 4.14.1" release, but it targets "---" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-bot · 2023-12-12T01:01:05Z

/bugzilla refresh

Recalculating validity in case the underlying Bugzilla bug has changed.

openshift-ci · 2023-12-12T01:01:11Z

@openshift-bot: This pull request references Bugzilla bug 2244609, which is invalid:

expected the bug to target the "ODF 4.14.1" release, but it targets "---" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-bot · 2023-12-13T01:01:07Z

/bugzilla refresh

Recalculating validity in case the underlying Bugzilla bug has changed.

openshift-ci · 2023-12-13T01:01:12Z

@openshift-bot: This pull request references Bugzilla bug 2244609, which is invalid:

expected the bug to target the "ODF 4.14.1" release, but it targets "---" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-bot · 2023-12-14T01:01:16Z

/bugzilla refresh

Recalculating validity in case the underlying Bugzilla bug has changed.

openshift-ci · 2023-12-14T01:01:21Z

@openshift-bot: This pull request references Bugzilla bug 2244609, which is invalid:

expected the bug to target the "ODF 4.14.1" release, but it targets "---" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-bot · 2023-12-15T01:01:07Z

/bugzilla refresh

Recalculating validity in case the underlying Bugzilla bug has changed.

openshift-ci · 2023-12-15T01:01:11Z

@openshift-bot: This pull request references Bugzilla bug 2244609, which is invalid:

expected the bug to target the "ODF 4.14.1" release, but it targets "---" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-bot · 2023-12-16T01:01:13Z

/bugzilla refresh

Recalculating validity in case the underlying Bugzilla bug has changed.

openshift-ci · 2023-12-16T01:01:17Z

@openshift-bot: This pull request references Bugzilla bug 2244609, which is invalid:

expected the bug to target the "ODF 4.14.1" release, but it targets "---" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

agarwal-mudit · 2023-12-16T03:51:52Z

/hold

openshift-ci · 2024-03-13T11:37:06Z

@parth-gr: This pull request references Bugzilla bug 2268174, which is invalid:

expected the bug to target the "ODF 4.14.6" release, but it targets "---" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci bot added bugzilla/severity-medium Referenced Bugzilla bug's severity is medium for the branch this PR is targeting. bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. labels Oct 18, 2023

parth-gr force-pushed the cluster_name branch from e933e3a to 9b5c3d0 Compare October 18, 2023 13:55

openshift-ci bot assigned BlaineEXE Oct 18, 2023

openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Oct 18, 2023

BlaineEXE reviewed Oct 18, 2023

View reviewed changes

external: change cluster_name to k8s_cluster_name

25db3cb

it was confusing if we are calling a ceph cluster name or k8s cluster name, so re-named Signed-off-by: parth-gr <paarora@redhat.com> (cherry picked from commit 98c4567) Signed-off-by: parth-gr <paarora@redhat.com>

parth-gr force-pushed the cluster_name branch from 9b5c3d0 to 25db3cb Compare October 25, 2023 08:54

openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Oct 25, 2023

BlaineEXE approved these changes Oct 26, 2023

View reviewed changes

openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Oct 26, 2023

openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 16, 2023

openshift-ci bot mentioned this pull request Feb 12, 2024

Bug 2244609: external: honour support of cluster-name legacy flag #554

Merged

7 tasks

parth-gr changed the title ~~Bug 2244609: external: change cluster_name to k8s_cluster_name~~ Bug 2268174: external: change cluster_name to k8s_cluster_name Mar 13, 2024

Bug 2268174: external: change cluster_name to k8s_cluster_name #530

Are you sure you want to change the base?

Bug 2268174: external: change cluster_name to k8s_cluster_name #530

Conversation

parth-gr commented Oct 18, 2023

openshift-ci bot commented Oct 18, 2023

BlaineEXE commented Oct 18, 2023

BlaineEXE Oct 18, 2023

Choose a reason for hiding this comment

parth-gr Oct 25, 2023

Choose a reason for hiding this comment

openshift-bot commented Oct 19, 2023

openshift-ci bot commented Oct 19, 2023

openshift-bot commented Oct 20, 2023

openshift-ci bot commented Oct 20, 2023

openshift-bot commented Oct 21, 2023

openshift-ci bot commented Oct 21, 2023

openshift-bot commented Oct 22, 2023

openshift-ci bot commented Oct 22, 2023

openshift-bot commented Oct 23, 2023

openshift-ci bot commented Oct 23, 2023

openshift-bot commented Oct 24, 2023

openshift-ci bot commented Oct 24, 2023

openshift-bot commented Oct 25, 2023

openshift-ci bot commented Oct 25, 2023

openshift-ci bot commented Oct 26, 2023

BlaineEXE commented Oct 26, 2023

travisn commented Oct 26, 2023

openshift-ci bot commented Dec 4, 2023

openshift-bot commented Dec 5, 2023

openshift-ci bot commented Dec 5, 2023

openshift-bot commented Dec 6, 2023

openshift-ci bot commented Dec 6, 2023

openshift-bot commented Dec 7, 2023

openshift-ci bot commented Dec 7, 2023

openshift-bot commented Dec 8, 2023

openshift-ci bot commented Dec 8, 2023

openshift-bot commented Dec 9, 2023

openshift-ci bot commented Dec 9, 2023

openshift-bot commented Dec 10, 2023

openshift-ci bot commented Dec 10, 2023

openshift-bot commented Dec 11, 2023

openshift-ci bot commented Dec 11, 2023

openshift-bot commented Dec 12, 2023

openshift-ci bot commented Dec 12, 2023

openshift-bot commented Dec 13, 2023

openshift-ci bot commented Dec 13, 2023

openshift-bot commented Dec 14, 2023

openshift-ci bot commented Dec 14, 2023

openshift-bot commented Dec 15, 2023

openshift-ci bot commented Dec 15, 2023

openshift-bot commented Dec 16, 2023

openshift-ci bot commented Dec 16, 2023

agarwal-mudit commented Dec 16, 2023

openshift-ci bot commented Mar 13, 2024