initial version of mintmaker service #3729
Conversation
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: scoheb The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
❗ Detected an outage of the following critical component(s)❗
Due to this issue E2E tests will probably fail. Please keep an eye on the following status pages: and add a comment |
2 similar comments
|
❗ Detected an outage of the following critical component(s)❗
Due to this issue E2E tests will probably fail. Please keep an eye on the following status pages: and add a comment |
|
❗ Detected an outage of the following critical component(s)❗
Due to this issue E2E tests will probably fail. Please keep an eye on the following status pages: and add a comment |
| @@ -0,0 +1,13 @@ | |||
| apiVersion: rbac.authorization.k8s.io/v1 | |||
| kind: RoleBinding | |||
| metadata: | ||
| name: crd-manager-for-mintmaker | ||
| rules: | ||
| - verbs: |
|
@scoheb before deploying it, I asked the mintmaker team for a technical overview. I would like to understand how this service is going to work and what it will require from the cluster. |
| kind: Kustomization | ||
| resources: | ||
| - ../base | ||
| - https://github.com/konflux-ci/mintmaker/config/default?ref=9e3dd3bfec43fbbae2d2dfb931f3f3cb082ae9af |
There was a problem hiding this comment.
The manifest brought by this revision do have kube linter issues, this needs to be fixed as we have a check for that, which is failing. Pasting the issues here so you do not have to drill down in the check logs:
<standard input>: (object: mintmaker/mintmaker-controller-manager apps/v1, Kind=Deployment) container "kube-rbac-proxy" does not have a read-only root file system (check: no-read-only-root-fs, remediation: Set readOnlyRootFilesystem to true in the container securityContext.)
<standard input>: (object: mintmaker/mintmaker-controller-manager apps/v1, Kind=Deployment) container "manager" does not have a read-only root file system (check: no-read-only-root-fs, remediation: Set readOnlyRootFilesystem to true in the container securityContext.)
- This is just a simple skeleton controller such that we can get mintmaker integrated. Signed-off-by: Scott Hebert <scoheb@gmail.com>
|
@scoheb: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
Can we have some context information added to this PR? The linked repo only seems to contain very basic auto-generated code and there is not much information in the README or any of the commits. We don't have any link here to any ADRs or Jira issues. "mintmaker" isn't a Google friendly term either. |
Hello, |
| apiVersion: rbac.authorization.k8s.io/v1 | ||
| metadata: | ||
| name: mintmaker-maintainers | ||
| namespace: mintmaker-service |
There was a problem hiding this comment.
Is this intended? Or should it be just mintmaker? I see in all other places it is mintmaker and not mintmaker-service.
@gnaponie thanks! Can you provide a link to a Jira issue tracking this work? Also ironing-out the technical details via the ADR process would be much appreciated, if it was not done yet. |
Sure! Here's the jira issue: https://issues.redhat.com/browse/CLOUDWF-10108 We have a document, but that perhaps it is a bit outdated. User stories and requirements in that document are in line with the request, but the actual technical details and proposal plan is a bit different. Would it be ok if I send that? |
|
So I've talked to @scoheb, and actually we've decided we're going to close this PR in favor of mine, which can be found here: #3798 |
|
closing in favour of 3798 |
that we can get mintmaker integrated.