-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(deps): update dependency eslint to v9 #1690
base: main
Are you sure you want to change the base?
Conversation
|
Hi @renovate[bot]. Thanks for your PR. I'm waiting for a redhat-appstudio member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
60096bd
to
94dbfd6
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1690 +/- ##
=============================================
+ Coverage 44.55% 56.25% +11.69%
=============================================
Files 279 14 -265
Lines 11973 2896 -9077
Branches 1433 0 -1433
=============================================
- Hits 5335 1629 -3706
+ Misses 6002 1052 -4950
+ Partials 636 215 -421 ☔ View full report in Codecov by Sentry. |
94dbfd6
to
57e29ab
Compare
@stuartwdouglas While most of the dependencies updates to eslint 9 ok it appears redhat-cloud-services/eslint-config-redhat-cloud-services is more problematic. It has https://github.com/RedHatInsights/frontend-components/blob/master/packages/eslint-config/package.json#L21 which conflicts with the major version upgrade with a conflicting peer dependency ( https://github.com/npm/rfcs/blob/main/implemented/0031-handling-peer-conflicts.md ). I think eslint-config-redhat-cloud-services dates from the creation of the console itself and whether we need it is another question? For that matter I don't think the eslint scripts are run/checked either? |
This PR contains the following updates:
^8.56.0
->^9.0.0
Release Notes
eslint/eslint (eslint)
v9.3.0
Compare Source
v9.2.0
Compare Source
v9.1.1
Compare Source
v9.1.0
Compare Source
v9.0.0
Compare Source
Configuration
📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.
🔕 Ignore: Close this PR and you won't be reminded about this update again.
This PR has been generated by Mend Renovate. View repository job log here.