Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): update dependency eslint to v9 #1690

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

renovate[bot]
Copy link
Contributor

@renovate renovate bot commented May 9, 2024

Mend Renovate

This PR contains the following updates:

Package Change Age Adoption Passing Confidence
eslint (source) ^8.56.0 -> ^9.0.0 age adoption passing confidence

Release Notes

eslint/eslint (eslint)

v9.3.0

Compare Source

v9.2.0

Compare Source

v9.1.1

Compare Source

v9.1.0

Compare Source

v9.0.0

Compare Source


Configuration

📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about this update again.


  • If you want to rebase/retry this PR, check this box

This PR has been generated by Mend Renovate. View repository job log here.

@renovate renovate bot added the ok-to-test label May 9, 2024
Copy link
Contributor Author

renovate bot commented May 9, 2024

⚠️ Artifact update problem

Renovate failed to update an artifact related to this branch. You probably do not want to merge this PR as-is.

♻ Renovate will retry this branch, including artifacts, only when one of the following happens:

  • any of the package files in this branch needs updating, or
  • the branch becomes conflicted, or
  • you click the rebase/retry checkbox if found above, or
  • you rename this PR's title to start with "rebase!" to trigger it manually

The artifact failure details are included below:

File name: java-components/management-console/src/main/webui/package-lock.json
npm error code ERESOLVE
npm error ERESOLVE could not resolve
npm error
npm error While resolving: @redhat-cloud-services/eslint-config-redhat-cloud-services@2.0.4
npm error Found: eslint@9.3.0
npm error node_modules/eslint
npm error   dev eslint@"^9.0.0" from the root project
npm error   peer eslint@"^7.5.0 || ^8.0.0 || ^9.0.0" from @babel/eslint-parser@7.24.5
npm error   node_modules/@babel/eslint-parser
npm error     @babel/eslint-parser@"^7.19.1" from @redhat-cloud-services/eslint-config-redhat-cloud-services@2.0.4
npm error     node_modules/@redhat-cloud-services/eslint-config-redhat-cloud-services
npm error       dev @redhat-cloud-services/eslint-config-redhat-cloud-services@"^2.0.3" from the root project
npm error   3 more (@eslint-community/eslint-utils, ...)
npm error
npm error Could not resolve dependency:
npm error peer eslint@"^8.9.0" from @redhat-cloud-services/eslint-config-redhat-cloud-services@2.0.4
npm error node_modules/@redhat-cloud-services/eslint-config-redhat-cloud-services
npm error   dev @redhat-cloud-services/eslint-config-redhat-cloud-services@"^2.0.3" from the root project
npm error
npm error Conflicting peer dependency: eslint@8.57.0
npm error node_modules/eslint
npm error   peer eslint@"^8.9.0" from @redhat-cloud-services/eslint-config-redhat-cloud-services@2.0.4
npm error   node_modules/@redhat-cloud-services/eslint-config-redhat-cloud-services
npm error     dev @redhat-cloud-services/eslint-config-redhat-cloud-services@"^2.0.3" from the root project
npm error
npm error Fix the upstream dependency conflict, or retry
npm error this command with --force or --legacy-peer-deps
npm error to accept an incorrect (and potentially broken) dependency resolution.
npm error
npm error
npm error For a full report see:
npm error /tmp/renovate/cache/others/npm/_logs/2024-05-27T06_25_58_576Z-eresolve-report.txt
npm error A complete log of this run can be found in: /tmp/renovate/cache/others/npm/_logs/2024-05-27T06_25_58_576Z-debug-0.log

Copy link
Contributor

openshift-ci bot commented May 9, 2024

Hi @renovate[bot]. Thanks for your PR.

I'm waiting for a redhat-appstudio member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@renovate renovate bot changed the title chore(deps): update dependency eslint to v9 Update dependency eslint to v9 May 14, 2024
@renovate renovate bot changed the title Update dependency eslint to v9 chore(deps): update dependency eslint to v9 May 14, 2024
@renovate renovate bot changed the title chore(deps): update dependency eslint to v9 Update dependency eslint to v9 May 14, 2024
@renovate renovate bot force-pushed the renovate/major-eslint-monorepo branch from 60096bd to 94dbfd6 Compare May 15, 2024 11:10
Copy link

codecov bot commented May 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 56.25%. Comparing base (134f203) to head (57e29ab).

Additional details and impacted files
@@              Coverage Diff              @@
##               main    #1690       +/-   ##
=============================================
+ Coverage     44.55%   56.25%   +11.69%     
=============================================
  Files           279       14      -265     
  Lines         11973     2896     -9077     
  Branches       1433        0     -1433     
=============================================
- Hits           5335     1629     -3706     
+ Misses         6002     1052     -4950     
+ Partials        636      215      -421     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@renovate renovate bot changed the title Update dependency eslint to v9 chore(deps): update dependency eslint to v9 May 27, 2024
@renovate renovate bot force-pushed the renovate/major-eslint-monorepo branch from 94dbfd6 to 57e29ab Compare May 27, 2024 06:26
@rnc
Copy link
Collaborator

rnc commented May 28, 2024

@stuartwdouglas While most of the dependencies updates to eslint 9 ok it appears redhat-cloud-services/eslint-config-redhat-cloud-services is more problematic. It has https://github.com/RedHatInsights/frontend-components/blob/master/packages/eslint-config/package.json#L21 which conflicts with the major version upgrade with a conflicting peer dependency ( https://github.com/npm/rfcs/blob/main/implemented/0031-handling-peer-conflicts.md ).

I think eslint-config-redhat-cloud-services dates from the creation of the console itself and whether we need it is another question? For that matter I don't think the eslint scripts are run/checked either?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant