-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Handle Nebula and StageVoteRelease plugins #1714
Conversation
Skipping CI for Draft Pull Request. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1714 +/- ##
============================================
- Coverage 44.59% 44.55% -0.05%
Complexity 802 802
============================================
Files 279 279
Lines 11951 11973 +22
Branches 1429 1433 +4
============================================
+ Hits 5330 5335 +5
- Misses 5988 6002 +14
- Partials 633 636 +3 ☔ View full report in Codecov by Sentry. |
@@ -69,7 +66,8 @@ echo "Running Gradle command with arguments: $@" | |||
if [ ! -d $(workspaces.source.path)/source ]; then | |||
cp -r $(workspaces.source.path)/workspace $(workspaces.source.path)/source | |||
fi | |||
gradle -Dmaven.repo.local=$(workspaces.source.path)/artifacts --info --stacktrace "$@" | tee $(workspaces.source.path)/logs/gradle.log | |||
# release.version is only for Nebula Release plugin. | |||
gradle -Dmaven.repo.local=$(workspaces.source.path)/artifacts --info --stacktrace -Prelease.version=$(params.PROJECT_VERSION) "$@" | tee $(workspaces.source.path)/logs/gradle.log |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can this go into build discovery instead so it ends up in the recipe? Also in general we should be referencing the env var version of PROJECT_VERSION rather than using the params. We should try and remove all copies of $(params) from the scripts and replace them with env vars at some point.
Ideally we would be able to encapsulate this within an init script and only activate it if the Nebula plugin is being used ; however I couldn't find any way of setting release.version there as opposed to from the cmd line.This is for micrometer and pgjdbc builds.