Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle Nebula and StageVoteRelease plugins #1714

Merged
merged 2 commits into from
May 21, 2024

Conversation

rnc
Copy link
Collaborator

@rnc rnc commented May 15, 2024

Ideally we would be able to encapsulate this within an init script and only activate it if the Nebula plugin is being used ; however I couldn't find any way of setting release.version there as opposed to from the cmd line.

This is for micrometer and pgjdbc builds.

Copy link
Contributor

openshift-ci bot commented May 15, 2024

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

Copy link

codecov bot commented May 15, 2024

Codecov Report

Attention: Patch coverage is 40.00000% with 6 lines in your changes are missing coverage. Please review.

Project coverage is 44.55%. Comparing base (0d34f5c) to head (12397fe).
Report is 23 commits behind head on main.

Files Patch % Lines
...ntainer/analyser/build/LookupBuildInfoCommand.java 0.00% 4 Missing and 2 partials ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main    #1714      +/-   ##
============================================
- Coverage     44.59%   44.55%   -0.05%     
  Complexity      802      802              
============================================
  Files           279      279              
  Lines         11951    11973      +22     
  Branches       1429     1433       +4     
============================================
+ Hits           5330     5335       +5     
- Misses         5988     6002      +14     
- Partials        633      636       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@rnc rnc marked this pull request as ready for review May 15, 2024 17:33
@@ -69,7 +66,8 @@ echo "Running Gradle command with arguments: $@"
if [ ! -d $(workspaces.source.path)/source ]; then
cp -r $(workspaces.source.path)/workspace $(workspaces.source.path)/source
fi
gradle -Dmaven.repo.local=$(workspaces.source.path)/artifacts --info --stacktrace "$@" | tee $(workspaces.source.path)/logs/gradle.log
# release.version is only for Nebula Release plugin.
gradle -Dmaven.repo.local=$(workspaces.source.path)/artifacts --info --stacktrace -Prelease.version=$(params.PROJECT_VERSION) "$@" | tee $(workspaces.source.path)/logs/gradle.log
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can this go into build discovery instead so it ends up in the recipe? Also in general we should be referencing the env var version of PROJECT_VERSION rather than using the params. We should try and remove all copies of $(params) from the scripts and replace them with env vars at some point.

@rnc rnc changed the title Handle Nebula plugin for micrometer build Handle Nebula and StageVoteRelease plugins May 20, 2024
@stuartwdouglas stuartwdouglas merged commit 34d370c into redhat-appstudio:main May 21, 2024
22 checks passed
@rnc rnc deleted the NEBULA branch May 21, 2024 06:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants