Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DRAFT :: CRW-3397 switch from vfs to fuse-overlayfs :: DO NOT MERGE before OCP 4.13 #341

Open
wants to merge 3 commits into
base: devspaces-3-rhel-8
Choose a base branch
from

Conversation

nickboldt
Copy link
Member

@nickboldt nickboldt commented Oct 17, 2022

What does this PR do?

CRW-3397 switch from vfs to fuse-overlayfs; add note about pinning to go 1.16 for golangci-lint 1.44.0 (CRW-3117)

Change-Id: Ib5fdfb77ebc5a58656615401a5faf1d4468d5454
Signed-off-by: Nick Boldt nboldt@redhat.com

Screenshot/screencast of this PR

N/A

What issues does this PR fix or reference?

N/A (or see commit message above for issue number)

How to test this PR?

N/A

PR Checklist

As the author of this Pull Request I made sure that:

Reviewers

Reviewers, please comment how you tested the PR when approving it.

… go 1.16 for golangci-lint 1.44.0 (CRW-3117)

Change-Id: Ib5fdfb77ebc5a58656615401a5faf1d4468d5454
Signed-off-by: Nick Boldt <nboldt@redhat.com>
@nickboldt nickboldt requested a review from svor October 17, 2022 16:42
@nickboldt nickboldt changed the title CRW-3397 switch from vfs to fuse-overlayfs;... CRW-3397 switch from vfs to fuse-overlayfs Oct 17, 2022
devspaces-udi/Dockerfile Outdated Show resolved Hide resolved
@svor
Copy link
Contributor

svor commented Oct 18, 2022

I'm not sure how to test this PR

@nickboldt
Copy link
Member Author

I was able to BUILD the change in downstream locally insofar as the correct configuration file was present (per https://github.com/containers/podman/blob/main/docs/tutorials/rootless_tutorial.md#ensure-fuse-overlayfs-is-installed ) and the version of fuse-overlayfs was 1.9.

But have not built a container and run it in OS to see what happens/breaks yet.

We could merge this, install DS 3.3 from quay IIB, and see if we can still podman pull and podman run from within a workspace.

@nickboldt
Copy link
Member Author

Due to kernel bug that won't be fixed before OCP 4.13 https://bugzilla.redhat.com/show_bug.cgi?id=2094060, marking this PR as draft / do not merge.

@nickboldt nickboldt changed the title CRW-3397 switch from vfs to fuse-overlayfs DRAFT :: CRW-3397 switch from vfs to fuse-overlayfs :: DO NOT MERGE before OCP 4.13 Oct 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants