chore: CRW-4642 - update to go 1.19 (since... #490
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…then run 'go mod tidy; go mod vendor' Change-Id: I9c2c162f10f0d4c4074fe66d68f2bae1f86e7033 Signed-off-by: Nick Boldt <nboldt@redhat.com>
ibuziuk
approved these changes
Aug 2, 2023
SDawley
approved these changes
Aug 22, 2023
|
is this not the change that was reverted upstream? looks very different from https://github.com/che-incubator/kubernetes-image-puller/pull/156/files |
|
That was crypto specifically, go stayed at 1.15 Maybe updating all of go instead of just crypto will fix the 'no utils' issue. I'll test it locally. |
|
OK not working locally. :/ But we should get back to this at some point because a number of the open CVEs I've looked at were regarding go. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
chore: CRW-4642 - update to go 1.19 (since we use that to build) and then run 'go mod tidy; go mod vendor'
Change-Id: I9c2c162f10f0d4c4074fe66d68f2bae1f86e7033
Signed-off-by: Nick Boldt nboldt@redhat.com
Screenshot/screencast of this PR
N/A
What issues does this PR fix or reference?
N/A (or see commit message above for issue number)
How to test this PR?
N/A
PR Checklist
As the author of this Pull Request I made sure that:
Reviewers
Reviewers, please comment how you tested the PR when approving it.