Regression fix: refer multiple services in custom mapping templates #955
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
service structs are initialized inside a `for range` loop, and the loop variable is passed as a reference to each of service structs. However, with each new iteration its value changes, but the reference remains the same, leading that the value of the last iteration is passed to all service structs eventually. * do not pass loop variable to service structs * unit tests were extended to detect regressions in the future * `Bind two backend services by creating 1 SBR to a single application` acceptance test was modified to detect regressions in the future Signed-off-by: Predrag Knezevic <pknezevi@redhat.com>
Codecov Report
@@ Coverage Diff @@
## master #955 +/- ##
==========================================
+ Coverage 53.69% 53.77% +0.07%
==========================================
Files 23 23
Lines 1231 1233 +2
==========================================
+ Hits 661 663 +2
Misses 480 480
Partials 90 90
Continue to review full report at Codecov.
|
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: pmacik The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
service structs are initialized inside a
for rangeloop, and the loop variable is passed as a reference to each of service structs.However, with each new iteration its value changes, but the reference remains the same, leading that the value of the last iteration
is passed to all service structs eventually.
Bind two backend services by creating 1 SBR to a single applicationacceptance test was modified to detect regressions in the futureFixes #944