[acceptance-tests] Add checks for removal of intermediate secret when SB is removed #957
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pmacik
changed the title
pmacik
changed the title
pmacik
force-pushed
the
unbind-delete-secret
branch
from
2cee69b
to
f2fd723
Compare
Codecov Report
@@ Coverage Diff @@
## master #957 +/- ##
=======================================
Coverage 53.77% 53.77%
=======================================
Files 23 23
Lines 1233 1233
=======================================
Hits 663 663
Misses 480 480
Partials 90 90 Continue to review full report at Codecov.
|
pedjak
suggested changes
Apr 26, 2021
Signed-off-by: Pavel Macík <pavel.macik@gmail.com>
pmacik
force-pushed
the
unbind-delete-secret
branch
from
f2fd723
to
55dc2dc
Compare
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: pedjak The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Currently the accepatce tests for unbinding are only checking that the injected binding information is removed from application when SB is removed. However a secret is created for SB and that secret should be removed as well and those tests are missing that check.
Changes
This PR adds checks for removal of intermediate secret when SB is removed
Testing
make test-acceptance