Check if unready binding can be removed #959
Conversation
pedjak
commented
Apr 30, 2021
pedjak
commented
- added missing acceptance tests
- in the reconcile loop, add finalizer only if deletion timestamp is unset
- unbind handler: stop processing and do not retry in case of any error when reading the application resource
pedjak
force-pushed
the
remove-not-ready-binding
branch
from
5fd9a83
to
08a0322
Compare
|
/retest |
Codecov Report
@@ Coverage Diff @@
## master #959 +/- ##
==========================================
+ Coverage 53.77% 54.27% +0.50%
==========================================
Files 23 23
Lines 1233 1227 -6
==========================================
+ Hits 663 666 +3
+ Misses 480 473 -7
+ Partials 90 88 -2
Continue to review full report at Codecov.
|
| * jq ".status.conditions[] | select(.type=="Ready").status" of Service Binding "unready-binding" should be changed to "False" | ||
| When Service binding "unready-binding" is deleted | ||
|
|
There was a problem hiding this comment.
line:194 -> unnecessary extra line
|
LGTM |
* added missing acceptance tests * in the reconcile loop, add finalizer only if deletion timestamp is unset * unbind handler: stop processing and do not retry in case of any error when reading the application resource Signed-off-by: Predrag Knezevic <pknezevi@redhat.com>
pedjak
force-pushed
the
remove-not-ready-binding
branch
from
08a0322
to
876b787
Compare
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: DhritiShikhar The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/lgtm |
