Optimize acceptance testing jobs on OpenShift CI #976
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Codecov Report
@@ Coverage Diff @@
## master #976 +/- ##
=======================================
Coverage 54.72% 54.72%
=======================================
Files 23 23
Lines 1239 1239
=======================================
Hits 678 678
Misses 473 473
Partials 88 88 Continue to review full report at Codecov.
|
pedjak
reviewed
Jun 10, 2021
pmacik
force-pushed
the
optimize-openshift-ci
branch
from
d7e1f11
to
5d85509
Compare
Signed-off-by: Pavel Macík <pavel.macik@gmail.com>
pmacik
force-pushed
the
optimize-openshift-ci
branch
from
5d85509
to
1ae7ad6
Compare
|
/retest |
3 similar comments
|
/retest |
|
/retest |
|
/retest |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Currenly, the acceptance testing jobs running with OpenShift CI build a custom test image in which they are executed. The acceptance tests are running in the local mode which means that couple of tools such as Go, operator-sdk and others are needed to build the operator binary locally.
Since #973 has been merged it is now possible and required to run acceptance tests on OpenShift with SBO installed in the cluster the test image only needs to be able to run the acceptance tests in the remote mode which requires only small number of tools like Python and make.
Additionally, having a
rootimage Dockerfile in a repository is making it hard to change since the way how OpenShift CI jobs work.ISSUE: https://issues.redhat.com/browse/APPSVC-884
Changes
This PR:
rootimage definition directly into the CI's job configuration (via [rhd-sbo] Install SBO from a catalog source instead of running local instance of SBO for acceptance tests openshift/release#14755)Testing
For further more details refer the CONTRIBUTING.md